Skip to content

Tipping banner does not scale properly based on viewport size #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Miyayes opened this issue Jan 9, 2019 · 1 comment
Closed

Tipping banner does not scale properly based on viewport size #2867

Miyayes opened this issue Jan 9, 2019 · 1 comment
Labels

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 9, 2019

Issue: Tipping banner does not scale properly based on viewport size. If viewport size is smaller than usual because of, e.g., docked dev tools, the tipping banner will appear shorter horizontally, and users will have to scroll side to side inside it to use it.

Even when the developer tools are later closed, the tipping banner does not scale back to proper size, but remains horizontally short.

UX symptom: Users cannot click outside the banner to close it, but instead need to press the X button. But the X button is outside view, so users have to know to scroll sideways to get to it.

Reproduce:

  1. Open a website you'd like to tip
  2. Open dev tools (docked on right side)
  3. Open tipping banner

image

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 9, 2019
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Jan 9, 2019
@rossmoody rossmoody self-assigned this Jan 20, 2019
@rossmoody rossmoody removed their assignment Feb 7, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@NejcZdovc
Copy link
Contributor

closing as dupe of #1658

@NejcZdovc NejcZdovc added closed/duplicate Issue has already been reported and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Apr 10, 2020
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Apr 10, 2020
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants