Skip to content

Fix SAND contract address in Sardine buy token list #28364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
muliswilliam opened this issue Feb 8, 2023 · 3 comments · Fixed by brave/brave-core#17095
Closed

Fix SAND contract address in Sardine buy token list #28364

muliswilliam opened this issue Feb 8, 2023 · 3 comments · Fixed by brave/brave-core#17095
Assignees
@muliswilliam
Labels
closed/invalid

Comments

@muliswilliam
Copy link

muliswilliam commented Feb 8, 2023 •
edited
Loading

The correct contract address for SAND should be 0x3845badAde8e6dFF049820680d1F14bD3903a5d0. The address in Sardine token list is 0x0000000000085d4780B73119b644AE5ecd22b376, it is incorrect.
@muliswilliam muliswilliam added this to Web3 Feb 8, 2023
@muliswilliam muliswilliam converted this from a draft issue Feb 8, 2023
@muliswilliam muliswilliam self-assigned this Feb 8, 2023
@muliswilliam muliswilliam moved this from Backlog to In Review in Web3 Feb 8, 2023
@muliswilliam muliswilliam mentioned this issue Feb 8, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Feb 8, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 8, 2023
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Mar 13, 2023
@srirambv
Copy link
Contributor

Marking issue as QA/Blocked since there is no value shown for the token in Buy widget. cc: @HEagle18 @muliswilliam

image

@srirambv
Copy link
Contributor

Moving this out of 1.50.x milestone as discussed here. @muliswilliam if we end up doing a different PR to fix this then please add a follow up issue for this and assign the appropriate milestone for it

cc: @HEagle18 @jamesmudgett @bbondy @kjozwiak for visibility

@srirambv srirambv removed this from the 1.50.x - Release milestone Mar 29, 2023
@muliswilliam
Copy link
Author

@srirambv Sardine removed SAND along with other tokens. This is the cause for the behaviour we have observed. I will update sardine token list to match the list on their end.
I have created an issue for this #29503

@kjozwiak kjozwiak removed this from Web3 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
closed/invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed SAND contract address in Sardine buy token list brave/brave-core
5 participants
@kjozwiak @srirambv @LaurenWags @brave-builds @muliswilliam