Skip to content

Move vpn helper crash dumps to accessible path #28343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spylogsster opened this issue Feb 7, 2023 · 4 comments · Fixed by brave/brave-core#17074
Closed

Move vpn helper crash dumps to accessible path #28343

spylogsster opened this issue Feb 7, 2023 · 4 comments · Fixed by brave/brave-core#17074

Comments

@spylogsster
Copy link

spylogsster commented Feb 7, 2023

If the service started by system it puts crashes to c:\Windows\System32\config\systemprofile\AppData\Local\BraveSoftware\Brave-Browser-Development\User Data\Crashpad\reports\ , need to save dumps to %PROGRAMDATA%\BraveSoftware\{service name}\Crashpad and update uploader to take crashes from this dir

@spylogsster spylogsster changed the title Add flag to crash service for testing Move vpn helper crash dumps to accessible path for uploader when started under system user Feb 7, 2023
@spylogsster spylogsster self-assigned this Feb 7, 2023
@spylogsster spylogsster changed the title Move vpn helper crash dumps to accessible path for uploader when started under system user Move vpn helper crash dumps to accessible path Feb 7, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 9, 2023
@stephendonner
Copy link

Note: this will be tested once, over in #25489. I think we can mark QA/No as we don't want to duplicate work.

Or, I guess we can de-scope #25489 to not cover crash reporting, and cover it here, instead?

@stephendonner
Copy link

@spylogsster @LaurenWags @kjozwiak thoughts on the above?

@LaurenWags
Copy link
Member

If it's fully covered by the testing in the issue you linked @stephendonner then I'm ok with QA/No, but I defer to @kjozwiak @spylogsster here since I don't have as much context.

@stephendonner
Copy link

Marking as QA/No - this was verified over in #25489 (comment) in the Crash reporting section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants