Skip to content

Issue with user rating card in news feed when toggling tab view #28315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Uni-verse opened this issue Feb 6, 2023 · 3 comments · Fixed by brave/brave-core#17302
Closed

Issue with user rating card in news feed when toggling tab view #28315

Uni-verse opened this issue Feb 6, 2023 · 3 comments · Fixed by brave/brave-core#17302

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 6, 2023

Description

This is an edge case, user must meet the conditions (Set default browser, 5 bookmarks or purchase VPN) to display the card. Rating card in news renders correctly initially but has issues when opening tab view and selecting tab again. Intermittent

Follow up to #25777

Steps to reproduce

  1. Install 1.48.x
  2. Launch App
  3. Enable Brave news via onboarding card
  4. Create 5 bookmarks
  5. Without closing app, manually set system time to 30 days ahead
  6. Bring app to foreground, user rating should be shown
  7. Close the first rating modal you see
  8. Scroll through news feed until you find the rate brave card
  9. Once its found, tap on the tab view and select the tab again
  10. Repeat a few times

Actual result

Example Example
screenshot-1675697818147 screenshot-1675697828679
news_rating_bug1.mp4

Expected result

screenshot-1675697653425

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes (Internal beta)
  • Can you reproduce this issue with the current Play Store Beta version? not tested
  • Can you reproduce this issue with the current Play Store Nightly version? not tested

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung GS 21, Samsung Tab S7
  • Android version: 13, 12

Brave version

1.48.157, Chromium 110.0.5481.77

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@deeppandya
Copy link
Contributor

Lets' aim for 1.49.x for the issue

@kjozwiak
Copy link
Member

kjozwiak commented Mar 6, 2023

The above requires 1.49.120 or higher for 1.49.x verification 👍

@Uni-verse
Copy link
Contributor Author

Verified on Samsung GS 21 5G using version:

Brave	1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit) 
Revision	c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS	Android 13; Build/TP1A.220624.014
  • Ensured that the user rating card presented in the news feed is displayed properly and does not break when opening/closing tab tray.
  • Ensured that user rating card is shown in the news feed after dismissing the NTP user rating popup.
Example Example
screenshot-1678292664819 screenshot-1678292689407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants