Skip to content

[Android] Rewards panel and brave://rewards should use the same rounding algorithm for balances #28258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephendonner opened this issue Feb 2, 2023 · 1 comment · Fixed by brave/brave-core#19600
Assignees
Labels
bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@stephendonner
Copy link

Description

Rewards panel and brave://rewards should use the same rounding algorithm for balances

Steps to reproduce

  1. install 1.48.154
  2. launch Brave
  3. set Rewards to staging via QA Preferences
  4. relaunch
  5. log in to a custodian (I tested with Gemini)
  6. do a couple one-time tips

Actual result

brave://rewards shows 1482.563
panel shows 1482.562

rewards-internals shows 1482.5625

brave://rewards panel brave://rewards-internals
Screenshot_20230202-091614 Screenshot_20230202-091621 Screenshot_20230202-091655

Expected result

Probably should round the Rewards panel the same way as we do in brave://rewards

Issue reproduces how often

100% (for me and my Gemini connected balance)

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): arm64
  • Device type (Phone, Tablet, Phablet): Google Pixel XL phone
  • Android version: 9

Brave version

1.48.154, Chromium 110.0.5481.52

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

/cc @LaurenWags @deeppandya @Miyayes @zenparsing @GeetaSarvadnya

@GeetaSarvadnya
Copy link

Verification PASSED on Vivo X70 Pro version12 running Bravemonoarm64.apk_1.59.86

rewards settings BR panle rewards internals
Screenshot_20230922_174119 Screenshot_20230922_174125 Screenshot_20230922_174206

@GeetaSarvadnya GeetaSarvadnya added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants