Skip to content

Cross-compiling from Linux to macOS does not create symlinks #27633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mherrmann opened this issue Jan 4, 2023 · 1 comment
Closed

Cross-compiling from Linux to macOS does not create symlinks #27633

mherrmann opened this issue Jan 4, 2023 · 1 comment
Assignees
@mherrmann
Labels
OS/Desktop OS/macOS QA/No release-notes/exclude

Comments

@mherrmann
Copy link

Brave's install dir (Brave Browser.app) on macOS has several symlinks. For example, Contents/Frameworks/Brave Browser Framework.framework/Resources symlinks to Versions/Current/Resources. Cross-compiling from Linux to macOS does not create those symlinks. Instead, full copies of the affected files/directories are created. This in particular breaks our delta updates.

Related to the original implementation brave/brave-core#13537.
@mherrmann mherrmann self-assigned this Jan 4, 2023
@mherrmann
Copy link
Author

I can no longer reproduce this. I suspect it was fixed by upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mherrmann mherrmann

Labels
OS/Desktop OS/macOS QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mherrmann