Skip to content

Switch over to Updated Nav #27008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Douglashdaniel opened this issue Nov 28, 2022 · 1 comment · Fixed by brave/brave-core#16104
Closed

Switch over to Updated Nav #27008

Douglashdaniel opened this issue Nov 28, 2022 · 1 comment · Fixed by brave/brave-core#16104
Assignees

Comments

@Douglashdaniel
Copy link

Description

Once Swap V2 is merged, we need to switch over to the new Buy/Send/Swap/Deposit nav.

Screen Shot 2022-11-28 at 10 04 00 AM

Screen Shot 2022-11-28 at 10 03 49 AM

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/swap labels Nov 28, 2022
@Douglashdaniel Douglashdaniel self-assigned this Nov 28, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Nov 28, 2022
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Nov 28, 2022
Repository owner moved this from In Review to Done in Web3 Nov 28, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Nov 28, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.48.139 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Linux
  • Verified steps from brave/brave-core#16104
  • Verified clicking on Send on portfolio page loads brave://wallet/send
  • Verified clicking on Swap on portfolio page loads brave://wallet/swap
  • Verified on brave://wallet/send page, clicking on Swap on the left navigation loads brave://wallet/swap
  • Verified other navigation buttons on the left work as expected
  • Verified new layout on panel is shown
  • Verified Buy button on panel loads brave://wallet/crypto/fund-wallet in a new tab
  • Verified Send button on panel loads brave://wallet/send in a new tab
  • Verified Swap button on panel loads brave://wallet/swap in a new tab
  • Verified Deposit button on panel loads brave://wallet/crypto/deposit-funds in a new tab
27008.mp4

Verification passed on

Brave 1.48.139 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16104
  • Verified clicking on Send on portfolio page loads brave://wallet/send
  • Verified clicking on Swap on portfolio page loads brave://wallet/swap
  • Verified on brave://wallet/send page, clicking on Swap on the left navigation loads brave://wallet/swap
  • Verified other navigation buttons on the left work as expected
  • Verified new layout on panel is shown
  • Verified Buy button on panel loads brave://wallet/crypto/fund-wallet in a new tab
  • Verified Send button on panel loads brave://wallet/send in a new tab
  • Verified Swap button on panel loads brave://wallet/swap in a new tab
  • Verified Deposit button on panel loads brave://wallet/crypto/deposit-funds in a new tab
27008.mp4

Verification passed on

Brave 1.48.139 Chromium: 109.0.5414.87 (Official Build) beta (arm64)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16104
  • Verified clicking on Send on portfolio page loads brave://wallet/send
  • Verified clicking on Swap on portfolio page loads brave://wallet/swap
  • Verified on brave://wallet/send page, clicking on Swap on the left navigation loads brave://wallet/swap
  • Verified other navigation buttons on the left work as expected
  • Verified new layout on panel is shown
  • Verified Buy button on panel loads brave://wallet/crypto/fund-wallet in a new tab
  • Verified Send button on panel loads brave://wallet/send in a new tab
  • Verified Swap button on panel loads brave://wallet/swap in a new tab
  • Verified Deposit button on panel loads brave://wallet/crypto/deposit-funds in a new tab
27008.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants