Skip to content

Monthly case show the text as "Tip Amount" #26348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sujitacharya2005 opened this issue Oct 28, 2022 · 3 comments · Fixed by brave/brave-core#15687
Closed

Monthly case show the text as "Tip Amount" #26348

sujitacharya2005 opened this issue Oct 28, 2022 · 3 comments · Fixed by brave/brave-core#15687

Comments

@sujitacharya2005
Copy link

sujitacharya2005 commented Oct 28, 2022

Description

  1. Set monthly tip
  2. In Confirmation screen show "Tip Amount"
  3. Instead of One-time tip Amount.

Steps to Reproduce

  1. Set monthly tip
  2. In Confirmation screen show "Tip Amount"
  3. Instead of One-time tip Amount.

Actual result:

Screenshot_20221028_153527

Expected result:

Screenshot_20221028_163007

Reproduces how often:

Easily reproduced

Brave version (info found on brave://version)

1.47.25

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@kjozwiak
Copy link
Member

Closing as this was addressed and fixed by brave/brave-core#15687.

@kjozwiak
Copy link
Member

The above requires 1.46.109 or higher for 1.46.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on Galaxy Tab A7 version 12 running Bravemonoarm64.apk_1.46.109

  • Ensured that Tip amount text is shown in the monthly tip confirmation screen
One time tip Monthly tip
Screenshot_20221114-231633_Brave - Beta Screenshot_20221114-231706_Brave - Beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants