-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Backend support for running DiscoverAssets on page refresh #25820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
feature/web3/wallet
Integrating Ethereum+ wallet support
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA Pass - Android ARM
QA Pass - Android Tab
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
25 tasks
Resolved by brave/brave-core#15707 |
Verification passed on
Verification passed on
Verification passed on
|
Verification passed on Oppo Reno 5 with Android 12 running 1.47.167 x64 build
Verification passed on Lenovo Tab with Android 12 running 1.47.167 x64 build
|
This was referenced Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/web3/wallet
Integrating Ethereum+ wallet support
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA Pass - Android ARM
QA Pass - Android Tab
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Currently the asset discovery logic is run when new accounts are added. With this approach we will not discover tokens sent to the user after they have added their account. Instead we should run asset discovery when the user refreshes the page, and have a message on pending response for auto-discovery cycle. Then throttle it to only call once every X minutes.
That way we will discover new assets, as well as discover assets for accounts added prior to the asset discovery feature.
The text was updated successfully, but these errors were encountered: