Skip to content

Backend support for running DiscoverAssets on page refresh #25820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nvonpentz opened this issue Oct 5, 2022 · 3 comments
Closed

Backend support for running DiscoverAssets on page refresh #25820

nvonpentz opened this issue Oct 5, 2022 · 3 comments

Comments

@nvonpentz
Copy link

nvonpentz commented Oct 5, 2022

Currently the asset discovery logic is run when new accounts are added. With this approach we will not discover tokens sent to the user after they have added their account. Instead we should run asset discovery when the user refreshes the page, and have a message on pending response for auto-discovery cycle. Then throttle it to only call once every X minutes.

That way we will discover new assets, as well as discover assets for accounts added prior to the asset discovery feature.

@nvonpentz nvonpentz added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Oct 5, 2022
@nvonpentz nvonpentz changed the title Run DiscoverAssets when new blocks are finalized Run DiscoverAssets on page refresh Oct 7, 2022
@nvonpentz nvonpentz changed the title Run DiscoverAssets on page refresh Backend support for running DiscoverAssets on page refresh Nov 4, 2022
@yrliou yrliou added this to Web3 Nov 11, 2022
@yrliou yrliou moved this to In Review in Web3 Nov 11, 2022
@yrliou
Copy link
Member

yrliou commented Nov 22, 2022

Resolved by brave/brave-core#15707

@yrliou yrliou closed this as completed Nov 22, 2022
Repository owner moved this from In Review to Done in Web3 Nov 22, 2022
@yrliou yrliou added this to the 1.47.x - Nightly milestone Nov 22, 2022
@srirambv
Copy link
Contributor

srirambv commented Jan 9, 2023

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (64-bit)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS Linux
  • Verified steps from brave/brave-core#13295
  • Verified restoring a wallet via seed shows all tokens that have balance across all accounts
  • Verified restoring an account via private key also restores/shows all tokens from that account in addition to already visible tokens
  • Verified restoring account via hardware wallet restores all the tokens from the account that have balance
  • Verified on a clean wallet Solana/ETH/BAT and EVM native tokens are listed as expected and no other tokens are listed

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (64-bit)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#13295
  • Verified restoring a wallet via seed shows all tokens that have balance across all accounts
  • Verified restoring an account via private key also restores/shows all tokens from that account in addition to already visible tokens
  • Verified restoring account via hardware wallet restores all the tokens from the account that have balance
  • Verified on a clean wallet Solana/ETH/BAT and EVM native tokens are listed as expected and no other tokens are listed

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (arm64)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#13295
  • Verified restoring a wallet via seed shows all tokens that have balance across all accounts
  • Verified restoring an account via private key also restores/shows all tokens from that account in addition to already visible tokens
  • Verified restoring account via hardware wallet restores all the tokens from the account that have balance
  • Verified on a clean wallet Solana/ETH/BAT and EVM native tokens are listed as expected and no other tokens are listed

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.47.167 x64 build

  • Verified test plan from brave/brave-core#13295
  • Verified restoring a wallet via seed shows all tokens that have balance across all accounts
  • Verified restoring an account via private key also restores/shows all tokens from that account in addition to already visible tokens
  • Verified on a clean wallet only Ethereum and BAT are listed as expected and no other tokens are listed

Verification passed on Lenovo Tab with Android 12 running 1.47.167 x64 build

  • Verified test plan from brave/brave-core#13295
  • Verified restoring a wallet via seed shows all tokens that have balance across all accounts
  • Verified restoring an account via private key also restores/shows all tokens from that account in addition to already visible tokens
  • Verified on a clean wallet only Ethereum and BAT are listed as expected and no other tokens are listed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants