Skip to content

Add Buy/Deposit buttons to Market Tab Tokens #25744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Douglashdaniel opened this issue Sep 30, 2022 · 1 comment · Fixed by brave/brave-core#15365
Closed

Add Buy/Deposit buttons to Market Tab Tokens #25744

Douglashdaniel opened this issue Sep 30, 2022 · 1 comment · Fixed by brave/brave-core#15365
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@Douglashdaniel
Copy link

Description

Add Buy and Deposit buttons to the Market tab tokens list.

Screen Shot 2022-09-30 at 2 09 13 PM
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Sep 30, 2022
@Douglashdaniel Douglashdaniel self-assigned this Sep 30, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Sep 30, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Oct 5, 2022
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Oct 5, 2022
Repository owner moved this from In Review to Done in Web3 Oct 6, 2022
@Douglashdaniel Douglashdaniel added this to the 1.46.x - Nightly milestone Oct 17, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.70 Chromium: 107.0.5304.36 (Official Build) beta (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Linux
  • Verified steps from brave/brave-core#15365
  • Verified Buy & Deposit buttons are shown next to tokens where supported
  • Verified for a few tokens only Deposit button is shown
  • Encountered #26246
25744.mp4

Verification passed on

Brave 1.46.70 Chromium: 107.0.5304.36 (Official Build) beta (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from brave/brave-core#15365
  • Verified Buy & Deposit buttons are shown next to tokens where supported
  • Verified for a few tokens only Deposit button is shown
  • Encountered #26246
25744.mp4

Verification passed on

Brave 1.46.70 Chromium: 107.0.5304.36 (Official Build) beta (arm64)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15365
  • Verified Buy & Deposit buttons are shown next to tokens where supported
  • Verified for a few tokens only Deposit button is shown
  • Encountered #26246
25744.mov

@LaurenWags LaurenWags mentioned this issue Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Buy Deposit Buttons in Market Tab brave/brave-core
2 participants
@srirambv @Douglashdaniel