Skip to content

Learn more links are in red instead of blue in dark mode #25224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srirambv opened this issue Sep 6, 2022 · 5 comments · Fixed by brave/brave-core#15319
Closed

Learn more links are in red instead of blue in dark mode #25224

srirambv opened this issue Sep 6, 2022 · 5 comments · Fixed by brave/brave-core#15319
Assignees
Labels
android-phone-specific bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 6, 2022

Description

Learn more links are in red instead of blue in dark mode

Steps to reproduce

  1. Create wallet, change theme to dark
  2. Select ETH
  3. Click on Bridge to Aurora button

Actual result

Expected result

Similar to tablet

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86):ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 12

Brave version

1.44.75 x64 Beta build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @Pavneet-Sing

@Pavneet-Sing
Copy link

Pavneet-Sing commented Sep 7, 2022

@srirambv this is an intended behaviour as the blue colour makes it hard to read due to poor contrast with dark theme, for e.g.

Screenshot from 2022-09-07 15-12-19

Desktop is using a little dark blue colour but still not a good contrast, specially for small screens.

ZCbDJ (1)

Brave theme colour works well for dark theme contrast, though let me know if we want to use a different colour or dark blue colour like desktop.

cc: @jamesmudgett

@jamesmudgett jamesmudgett moved this to Backlog in Web3 Sep 9, 2022
@jamesmudgett
Copy link

#A0A5EB

Image

@srirambv
Copy link
Contributor Author

@Pavneet-Sing @jamesmudgett can you confirm if the button text should be blue for both dark & light or just for light theme?

@Pavneet-Sing
Copy link

Pavneet-Sing commented Sep 12, 2022

light dark
image Screenshot from 2022-09-12 17-43-12

@srirambv yes, blue for both.

@Pavneet-Sing Pavneet-Sing changed the title Learn more links are in red instead of blue Learn more links are in red instead of blue in dark mode Sep 13, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Oct 3, 2022
Repository owner moved this from Backlog to Done in Web3 Oct 3, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Oct 3, 2022
@srirambv
Copy link
Contributor Author

Verification passed on Oppo Reno 5 with Android 12 running 1.46.70 x64 Beta build

  • Verified steps from issue description
  • Verified Learn more links are in blue in dark/light mode
25224.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-phone-specific bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants