Skip to content

Support ENS wildcard resolution #24430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
supermassive opened this issue Aug 4, 2022 · 2 comments · Fixed by brave/brave-core#15317
Closed

Support ENS wildcard resolution #24430

supermassive opened this issue Aug 4, 2022 · 2 comments · Fixed by brave/brave-core#15317
Assignees
@supermassive
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@supermassive
Copy link

To complete support of ENS L2 #22930 we also need support of wildcard resolution for ENS https://docs.ens.domains/ens-improvement-proposals/ensip-10-wildcard-resolution
@supermassive supermassive added OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/core labels Aug 4, 2022
@supermassive supermassive self-assigned this Aug 4, 2022
@yrliou yrliou added this to Web3 Aug 29, 2022
@yrliou yrliou added feature/web3/wallet Integrating Ethereum+ wallet support priority/P3 The next thing for us to work on. It'll ride the trains. labels Aug 29, 2022
@yrliou yrliou moved this to Backlog in Web3 Aug 29, 2022
@supermassive supermassive mentioned this issue Oct 3, 2022
Merged
25 tasks
Repository owner moved this from Backlog to Done in Web3 Oct 10, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Oct 10, 2022
@srirambv
Copy link
Contributor

Discussed with @supermassive here and removing OS/Android label from this as the implementation needs to be done Android.

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Oct 21, 2022
@srirambv srirambv mentioned this issue Oct 21, 2022
Open
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Linux
  • Verified as Send To address resolution as part of #24990 (comment)
  • Verified entering offchainexample.eth in omnibox shows IPFS interstitial page
  • Verified able to load the page either via local address resolution or via public dns resolution
24430.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified as Send To address resolution as part of #24990 (comment)
  • Verified entering offchainexample.eth in omnibox shows IPFS interstitial page
  • Verified able to load the page either via local address resolution or via public dns resolution
24430.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (arm64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 12.6 (Build 21G115)
  • Verified as Send To address resolution as part of #24990 (comment)
  • Verified entering offchainexample.eth in omnibox shows IPFS interstitial page
  • Verified able to load the page either via local address resolution or via public dns resolution
24430.mov

@srirambv srirambv mentioned this issue Oct 31, 2022
Closed
@LaurenWags LaurenWags mentioned this issue Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

Ensl2 wildcards and noensip10 brave/brave-core
4 participants
@supermassive @yrliou @srirambv @brave-builds