Skip to content

[Android] Follow up to #20980 - Routinely clear out or expire stale creator info from publisher_info_db #23995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Uni-verse opened this issue Jul 12, 2022 · 2 comments
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@Uni-verse
Copy link
Contributor

Description

Routinely clear out or expire stale creator info from publisher_info_db

Details on #20980

Steps to reproduce

  1. Own twitter / youtube page
  2. Login into twitter or youtube profile page
  3. Login to creators.brave.com and add creator channel you own
  4. Open BR panel on twitter/youtube profile page, take note of the publisher name displayed
  5. Load the settings page and update the username or channel name
  6. Return to profile page (Step 4) and re-check the BR panel publisher name

Actual result

Publisher name should be updated

Example Example
screenshot-1657584465164 screenshot-1657584852892

Expected result

Publisher name not updated

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? yes
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Galaxy Devices
  • Android version: 12

Brave version

1.41.95

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@kjozwiak
Copy link
Member

CCing @Miyayes

@Miyayes Miyayes changed the title Follow up to #20980 - Routinely clear out or expire stale creator info from publisher_info_db [Android] [Android] Follow up to #20980 - Routinely clear out or expire stale creator info from publisher_info_db Jul 12, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Jul 13, 2022

Changes were in Greaselion, so that is why they probably didn't propagate to Android. Will need an Android-specific implementation.

@Miyayes Miyayes added priority/P4 Planned work. We expect to get to it "soon". priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jul 13, 2022
@deeppandya deeppandya added priority/P3 The next thing for us to work on. It'll ride the trains. and removed bug feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes labels Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

5 participants