Skip to content

Implement Solana SignAndSendTransaction, SignTransaction, and SignAllTransactions in Wallet UI #23369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
josheleonard opened this issue Jun 9, 2022 · 2 comments · Fixed by brave/brave-core#13666
Closed

Implement Solana SignAndSendTransaction, SignTransaction, and SignAllTransactions in Wallet UI #23369

josheleonard opened this issue Jun 9, 2022 · 2 comments · Fixed by brave/brave-core#13666
Assignees
@josheleonard @Douglashdaniel
Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude security
Milestone
1.41.x - Release

Comments

@josheleonard
Copy link

Description

Implement UI for the following Solana Dapp requests

  • SignAndSendTransaction
  • SignTransaction
  • SignAllTransactions

Actual result:

see: brave/brave-core#13439

Expected result:

When signing Solana dapp transactions, the UI should display relevant information regarding the pending signature request.
@josheleonard josheleonard added this to the 1.41.x - Nightly milestone Jun 9, 2022
@josheleonard josheleonard self-assigned this Jun 9, 2022
@josheleonard josheleonard added this to Web3 Jun 9, 2022
@josheleonard josheleonard mentioned this issue Jun 9, 2022
Merged
25 tasks
@josheleonard josheleonard moved this to In Review in Web3 Jun 9, 2022
@Douglashdaniel Douglashdaniel self-assigned this Jun 14, 2022
@Douglashdaniel Douglashdaniel added front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/solana labels Jun 17, 2022
Repository owner moved this from In Review to Done in Web3 Jun 21, 2022
@kjozwiak kjozwiak mentioned this issue Jun 24, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

The above will require 1.41.80 or higher for 1.41.x verification 👍

@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Jun 27, 2022
@srirambv
Copy link
Contributor

srirambv commented Jul 1, 2022

Brave 1.41.86 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
Revision 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708) 		☑️ macOS Version 12.0.1
(Build 21C52)
23369-Linux.mp4
23369-Windows.mp4
23369-macOS.mov

@srirambv srirambv mentioned this issue Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude security
Projects
Web3
Archived in project
Milestone
1.41.x - Release
5 participants
@kjozwiak @srirambv @LaurenWags @josheleonard @Douglashdaniel