Skip to content

[De-AMP] Fix test cases for looping checks #23058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ShivanKaul opened this issue May 25, 2022 · 0 comments · Fixed by brave/brave-core#13467
Closed

[De-AMP] Fix test cases for looping checks #23058

ShivanKaul opened this issue May 25, 2022 · 0 comments · Fixed by brave/brave-core#13467
Assignees
@ShivanKaul
Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop privacy/de-amp QA/No release-notes/exclude
Milestone
1.39.x - Release #3

Comments

@ShivanKaul
Copy link
Collaborator

Related to brave/brave-core#13213:

  1. Add check for De-AMPed header - make sure it's never sent to server
  2. Make sure navigation starts at AMP URL in test case
@ShivanKaul ShivanKaul added dev-concern release-notes/exclude OS/Android Fixes related to Android browser functionality OS/Desktop labels May 25, 2022
@ShivanKaul ShivanKaul added this to the 1.41.x - Nightly milestone May 25, 2022
@ShivanKaul ShivanKaul self-assigned this May 25, 2022
@ShivanKaul ShivanKaul mentioned this issue May 25, 2022
Merged
25 tasks
This was referenced Jun 7, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShivanKaul ShivanKaul

Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop privacy/de-amp QA/No release-notes/exclude
Projects
None yet
Milestone
1.39.x - Release #3
Development

Successfully merging a pull request may close this issue.

Modify tests for looping checks brave/brave-core
2 participants
@kjozwiak @ShivanKaul