CAPTCHA not being displayed within rewards panel when initiated via brave://rewards

[kjozwiak]

Description

CAPTCHA isn't being launched via the rewards panel when initiated using brave://rewards. Once you've dismissed the initial Claim Rewads button/modal that appears within the panel, you don't be able to claim your rewards via brave://settings due to the CAPTCHA not appearing in the panel.

Steps to Reproduce

1. launch brave using --rewards=staging=true --brave-ads-staging
2. click on the rewards panel and run through the onboarding
3. once you've stepped through all the onboarding screens, tap in X to dismiss the Claim Rewards modal
4. once dismissed, go into brave://rewards and attempt to claim the reward/grant

Actual result:

broken.mp4

Expected result:

working.mp4

Reproduces how often:

100% reproducible when using the STR/Cases outlined above.

Brave version (brave://version info)

Brave | 1.39.73 Chromium: 101.0.4951.34 (Official Build) nightly (64-bit)
-- | --
Revision | 8f93af5d759634c5256b65997dedd138ed60992f-refs/branch-heads/4951@{#710}
OS | Windows 11 Version 21H2 (Build 22000.613)

Brave | 1.39.72 Chromium: 101.0.4951.34 (Official Build) nightly (x86_64)
--- | ---
Revision | 8f93af5d759634c5256b65997dedd138ed60992f-refs/branch-heads/4951@{#710}
OS | macOS Version 12.3.1 (Build 21E258)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? No (need to wait for a 1.39.x BETA to check)
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @emerick @Miyayes @LaurenWags @zenparsing

[GeetaSarvadnya]

Reproduced the issue in Windows 10 x64 - 1.39.73

Brave | 1.39.73 Chromium: 101.0.4951.34 (Official Build) nightly (64-bit)
-- | --
Revision | 8f93af5d759634c5256b65997dedd138ed60992f-refs/branch-heads/4951@{#710}
OS | Windows 10 Version 21H2 (Build 19044.1645)

[kjozwiak]

The above requires 1.39.80 or higher for 1.39.x verification.

[MadhaviSeelam]

Verification PASSED using

Brave	1.39.83 Chromium: 101.0.4951.41 (Official Build) beta (64-bit)
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	Windows 11 Version 21H2 (Build 22000.613)

Test Case 1: Verified CAPTCHA displayed when initiated from brave://rewards after dismissing initial Claim Tokens modal

• Install 1.39.83
• Launch brave using --rewards=staging=true --brave-ads-staging
• Click Skip welcome tour
• Click BAT icon in the URL bar to open onboarding modal
• Click Start using Brave Rewards to complete onboarding process
• Click X to dismiss the A token grant is available/Claim Tokens modal
• Go to brave://rewards and click blue CLAIM button above rewards panel
• CAPTCHA is displayed and solved to claim the grant

Note: Below are regression test cases to test all flows.

Test Case 2: Verified CAPTCHA displayed when clicked on Claim Tokens button in the rewards panel

• New profile
• Launch brave using --rewards=staging=true --brave-ads-staging
• Click Skip welcome tour
• Click BAT icon in the URL bar to open onboarding modal
• Click Start using Brave Rewards to complete onboarding process
• Click Claim Tokens button in the modal
• CAPTCHA is displayed and solved to claim the grant

ex1	ex2	ex3	ex4	ex5	ex6	ex7	ex8

Test Case 3: Complete onboarding from brave://rewards and click Claim button to launch CAPTCHA in the rewards page

• New profile
• Launch brave with using --rewards=staging=true --brave-ads-staging
• Navigate to brave://rewards
• Click Start using Brave Rewards on the rewards page to complete onboarding process
• Click blue CLAIM button above rewards panel
• CAPTCHA is displayed and solved to claim the grant

ex1	ex2	ex3	ex4	ex5	ex6

Test Case 4: Launch onboarding from Brave rewards widget in NTP and initiate CAPTCHA via brave://rewards

• New profile
• Launch brave using --rewards=staging=true --brave-ads-staging
• Complete welcome tour
• Click Start using Rewards button on the Brave rewards widget
• Click Start using Brave Rewards to complete onboarding process
• Click X to dismiss the Claim Tokens modal
• Go to brave://rewards and click blue CLAIM button above rewards panel
• CAPTCHA is displayed and solved to claim the grant

ex1	ex2	ex3	ex4	ex5	ex6	ex7	ex8	ex9

Test Case 5: Launch onboarding from Brave rewards box in NTPSI and initiate CAPTCHA via brave://rewards

• New profile
• Launch brave with using --rewards=staging=true --brave-ads-staging
• Open a NTP and refresh to view NTPSI
• Click Start using Rewards Brave Rewards box
• Click Start using Brave Rewards to complete onboarding process
• Click X to dismiss the Claim Tokens modal
• Go to brave://rewards and click blue CLAIM button above rewards panel
• CAPTCHA is displayed and solved to claim the grant

ex1	ex2	ex3	ex4	ex5	ex6	ex7

[LaurenWags]

Verified with

Brave | 1.39.86 Chromium: 101.0.4951.41 (Official Build) beta (x86_64)
-- | --
Revision | 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS | macOS Version 12.3.1 (Build 21E258)

Test Case 1: Verified CAPTCHA displayed when initiated from brave://rewards after dismissing initial Claim Tokens modal

• Install 1.39.x
• Launch brave using --rewards=staging=true --brave-ads-staging
• Click Skip welcome tour
• Click BAT icon in the URL bar to open onboarding modal
• Click Start using Brave Rewards to complete onboarding process
• Click X to dismiss the A token grant is available/Claim Tokens modal
• Go to brave://rewards and click blue CLAIM button above rewards panel
• CAPTCHA is displayed and solved to claim the grant

Example	Example

Test Case 2: Verified CAPTCHA displayed when clicked on Claim Tokens button in the rewards panel

• New profile
• Launch brave using --rewards=staging=true --brave-ads-staging
• Click BAT icon in the URL bar to open onboarding modal
• Click Start using Brave Rewards to complete onboarding process
• Click Claim Tokens button in the modal
• CAPTCHA is displayed and solved to claim the grant

Example	Example

Test Case 3: Complete onboarding from brave://rewards and click Claim button to launch CAPTCHA in the rewards page

• New profile
• Launch brave with using --rewards=staging=true --brave-ads-staging
• Navigate to brave://rewards
• Click Start using Brave Rewards on the rewards page to complete onboarding process
• Click blue CLAIM button above rewards panel
• CAPTCHA is displayed and solved to claim the grant

Example	Example

Test Case 4: Launch onboarding from Brave rewards widget in NTP and initiate CAPTCHA via NTP

• New profile
• Launch brave using --rewards=staging=true --brave-ads-staging
• Complete welcome tour
• Click Start using Rewards button on the Brave rewards widget
• Click Start using Brave Rewards to complete onboarding process
• Click X to dismiss the Claim Tokens modal
• Go to brave://rewards and click blue CLAIM button above rewards panel
• CAPTCHA is displayed and solved to claim the grant

Example	Example

[btlechowski]

Verification passed on

Brave	1.39.100 Chromium: 101.0.4951.61 (Official Build) beta (64-bit)
Revision	3b3633b32c491b4cba5fd7df3c7c0f628547cbcc-refs/branch-heads/4951@{#1189}
OS	Ubuntu 18.04 LTS

Test Case 1: Verified CAPTCHA displayed when initiated from brave://rewards after dismissing initial Claim Tokens modal

• Install 1.39.x
• Launch brave using --rewards=staging=true --brave-ads-staging
• Click Skip welcome tour
• Click BAT icon in the URL bar to open onboarding modal
• Click Start using Brave Rewards to complete onboarding process
• Click X to dismiss the A token grant is available/Claim Tokens modal
• Go to brave://rewards and click blue CLAIM button above rewards panel
• CAPTCHA is displayed and solved to claim the grant

Note: Below are regression test cases to test all flows.

Test Case 2: Verified CAPTCHA displayed when clicked on Claim Tokens button in the rewards panel

• New profile
• Launch brave using --rewards=staging=true --brave-ads-staging
• Click Skip welcome tour
• Click BAT icon in the URL bar to open onboarding modal
• Click Start using Brave Rewards to complete onboarding process
• Click Claim Tokens button in the modal
• CAPTCHA is displayed and solved to claim the grant

Test Case 3: Complete onboarding from brave://rewards and click Claim button to launch CAPTCHA in the rewards page

• New profile
• Launch brave with using --rewards=staging=true --brave-ads-staging
• Navigate to brave://rewards
• Click Start using Brave Rewards on the rewards page to complete onboarding process
• Click blue CLAIM button above rewards panel
• CAPTCHA is displayed and solved to claim the grant

Test Case 4: Launch onboarding from Brave rewards widget in NTP and initiate CAPTCHA via brave://rewards

• New profile
• Launch brave using --rewards=staging=true --brave-ads-staging
• Complete welcome tour
• Click Start using Rewards button on the Brave rewards widget
• Click Start using Brave Rewards to complete onboarding process
• Click X to dismiss the Claim Tokens modal
• Go to brave://rewards and click blue CLAIM button above rewards panel
• CAPTCHA is displayed and solved to claim the grant

Test Case 5: Launch onboarding from Brave rewards box in NTPSI and initiate CAPTCHA via brave://rewards

• New profile
• Launch brave with using --rewards=staging=true --brave-ads-staging
• Open a NTP and refresh to view NTPSI
• Click Start using Rewards Brave Rewards box
• Click Start using Brave Rewards to complete onboarding process
• Click X to dismiss the Claim Tokens modal
• Go to brave://rewards and click blue CLAIM button above rewards panel
• CAPTCHA is displayed and solved to claim the grant