Skip to content

Unblinded token confirmation does not contain catalog id #22279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
btlechowski opened this issue Apr 13, 2022 · 2 comments · Fixed by brave/brave-core#13007
Closed

Unblinded token confirmation does not contain catalog id #22279

btlechowski opened this issue Apr 13, 2022 · 2 comments · Fixed by brave/brave-core#13007
Assignees
@tmancey
Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.38.x - Release

Comments

@btlechowski
Copy link

btlechowski commented Apr 13, 2022 •
edited
Loading

Follow up to #18100 Add RPill to unblinded token and unblinded payment token redemption

Steps to Reproduce

  1. Check Unblinded token confirmation request for id

Actual result:

'id' is missing

Expected result:

'id' is included in the request

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.38.83 Chromium: 100.0.4896.79 (Official Build) beta (64-bit
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS Ubuntu 18.04 LTS

cc @brave/qa-team @tmancey @jsecretan
@tmancey tmancey added bug priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 13, 2022
@tmancey tmancey self-assigned this Apr 13, 2022
@tmancey tmancey mentioned this issue Apr 13, 2022
Merged
25 tasks
@btlechowski btlechowski changed the title Unblinded token confirmation and unblinded payment tokens redemption requests do not contain catalog id Unblinded token confirmation does not contain catalog id Apr 13, 2022
@tmancey tmancey mentioned this issue Apr 13, 2022
Merged
4 tasks
@tmancey tmancey added this to the 1.39.x - Nightly milestone Apr 13, 2022
@kjozwiak
Copy link
Member

Above requires 1.38.95 or higher for 1.38.x verification.

@btlechowski
Copy link
Author

Verification passed on

Brave 1.38.96 Chromium: 100.0.4896.88 (Official Build) beta (64-bit)
Revision 4450653bfa91182e85723d8f1dee64dd6ce40ed4-refs/branch-heads/4896@{#1086}
OS Ubuntu 18.04 LTS

Verified id is included in the confirmation

image

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

Unblinded token confirmation requests do not contain catalog id brave/brave-core
3 participants
@tmancey @kjozwiak @btlechowski