Brave crash after changing the shield settings

[GeetaSarvadnya]

Description

Brave crash after changing the shield settings

Steps to Reproduce

1. Clean profile 1.38.x
2. Open a cnn.com website in win 1 and theverge.com in win 2
3. Open the shield panel and change the shield settings to "Allow" and then "Aggressive" and then "Block" in win 1
4. Keep the browser idle for 15 to 20 mins
5. Open the browser and try to change the shield settings in win1
6. Brave crashes

Actual result:

Brave crash

Expected result:

Should not be any crash

Reproduces how often:

80%

Brave version (brave://version info)

Brave	1.38.90 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision	8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS	Windows 10 Version 21H2 (Build 19044.1586)

## Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron

[GeetaSarvadnya]

Now I can reproduce the issue consistently. The steps followed are as below

• Clean profile 1.39.x
• Open a cnn.com in tab 1 and theverge.com in tab 2
• Open theverge.com in win2 (by dragging the tab)
• Keep both the windows side by side
• Change the shield setting for cnn.com in win 1 (Allow ->Aggressive->Block)
• Set the focus on other apps (e.g slack or chrome)
• Wait for ~2 mins
• Open the cnn.com and try to change the shield settings brave crashes

Status:	Uploaded
Uploaded Crash Report ID:	f3140000-fb20-0d08-0000-000000000000
Upload Time:	Wednesday, April 13, 2022 at 11:41:08 PM

Uploaded Crash Report ID: | fa170000-fb20-0d08-0000-000000000000
Upload Time: | Thursday, April 14, 2022 at 12:03:12 AM

@nullhook @simonhong

[rebron]

cc: @iefremov

[nullhook]

This needs to be re-tested after brave/brave-core#13029 gets uplifted

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.38.103 Chromium: 100.0.4896.127 (Official Build) beta (64-bit)
-- | --
Revision | ff0d0695743e65305d7194f9bd309e5e1c824aa0-refs/branch-heads/4896_88@{#4}
OS | Windows 10 Version 21H2 (Build 19044.1645)

• Verified the STR from the issue and ensured there is no crash when shield settings are changed in two windows

[stephendonner]

Verified PASSED using

Brave	1.38.105 Chromium: 101.0.4951.41 (Official Build) (x86_64)
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	macOS Version 11.6.5 (Build 20G527)

Also confirmed no crash with the steps to reproduce from this issue, and exploratory testing 👍