Skip to content

[perf] Estimate Adblock performance impact #21603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
atuchin-m opened this issue Mar 11, 2022 · 3 comments
Open

[perf] Estimate Adblock performance impact #21603

atuchin-m opened this issue Mar 11, 2022 · 3 comments
Assignees
@atuchin-m
Labels
OS/Desktop perf

Comments

@atuchin-m
Copy link
Contributor

  1. Make a manual comparison Brave (without AdBlock) vs Brave(with AdBlock) vs Chrome (+uBlock) in terms of memory, CPU usage, and browsing speed;
  2. Enable reward in some perf test configuration (=Adblock code should be covered by perf tests).
@atuchin-m atuchin-m self-assigned this Mar 11, 2022
@atuchin-m atuchin-m mentioned this issue Mar 21, 2022
Open
@atuchin-m
Copy link
Contributor Author

atuchin-m commented Mar 23, 2022 •
edited
Loading

Here is the heap diff when loading adblock component on win_x64: +29.64mb
image

@atuchin-m atuchin-m mentioned this issue Mar 28, 2022
Closed
@antonok-edm
Copy link
Collaborator

Some memory should be saved by #21970 / brave/brave-core#12824

@atuchin-m
Copy link
Contributor Author

Also I've found that lazy CompiledRegex can takes a crazy amount of memory.
If you create all of 6k in the test set it consumes 1Gb. Trying to investigate why and find an alternatives.

@atuchin-m atuchin-m mentioned this issue Apr 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atuchin-m atuchin-m

Labels
OS/Desktop perf
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antonok-edm @atuchin-m