Skip to content

[Android] Add QR code scanner to address bar #21478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timchilds opened this issue Mar 4, 2022 · 2 comments · Fixed by brave/brave-core#14675
Closed

[Android] Add QR code scanner to address bar #21478

timchilds opened this issue Mar 4, 2022 · 2 comments · Fixed by brave/brave-core#14675
Assignees
Labels
feature-request needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@timchilds
Copy link

timchilds commented Mar 4, 2022

Summary
A QR code scanner is already available in the iOS app. We should add the same feature to Android to be consistent.

Requirements

  • When the URL bar is tapped, display a QR icon in the address bar (to the left of voice search icon).
  • On tap, opens a QR scanner in modal (same modal stye as tab groups?)
  • On successful scan, opens website.
  • Include back icon for user to back out of the QR scanner (see mockup).
  • Copy: same as iOS (see mockup).

Mockup
image

@anthonypkeane anthonypkeane added priority/P3 The next thing for us to work on. It'll ride the trains. feature-request needs-more-info The report requires more detail before we can decide what to do with this issue. labels Mar 4, 2022
@aman-m1
Copy link

aman-m1 commented Mar 7, 2022

Can we have the ability to scan QR code from a file (image) as well that can be picked from device?

@tapanmodh tapanmodh added this to the 1.45.x - Nightly milestone Aug 26, 2022
@tapanmodh tapanmodh added the OS/Android Fixes related to Android browser functionality label Aug 26, 2022
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 19, 2022
@Uni-verse
Copy link
Contributor

Verified using the following build(s):

Brave	1.45.106 Chromium: 107.0.5304.36 (Official Build) (64-bit) 
Revision	2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS	Android 12; Build/SP1A.210812.016
  • Verified QR code scanner icon is in the url bar when curser is present
  • Verified tapping code scanner will launch the modal
  • Verified webpage is loaded on successful scan
  • Verified tapper the back arrow will close the QR code scanner modal
  • Verified scanning webpage url will launch the webpage or populate in the url box
  • Verified scanning QR code for crypto wallet address populates the value in the url box
  • Verified copy is same as on iOS
Example Example Example
screenshot-1666189176599 screenshot-1666189203869 screenshot-1666190508754
screenshot-1666195128052 screenshot-1666195229939 screenshot-1666195112128

@Uni-verse Uni-verse added QA Pass - Android ARM QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants