Skip to content

Ads process runs into issuers request infinite loop. #19991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aseren opened this issue Dec 8, 2021 · 3 comments · Fixed by brave/brave-core#11513
Closed

Ads process runs into issuers request infinite loop. #19991

aseren opened this issue Dec 8, 2021 · 3 comments · Fixed by brave/brave-core#11513
Assignees

Comments

@aseren
Copy link

aseren commented Dec 8, 2021

Issue is reproduced for me on fresh master branch. The problem is that retry is happening immediatly but should has exponential backoff. Ads log extract:

[Dec 08, 2021, 7:53:50.3 PM:ERROR:account.cc(186)] Invalid issuers
[Dec 08, 2021, 7:53:50.3 PM:INFO:issuers.cc(131)] Fetch issuers in 0 hours, 0 minutes, 0 seconds at 7:53 PM
[Dec 08, 2021, 7:53:50.3 PM:INFO:issuers.cc(66)] GetIssuers
[Dec 08, 2021, 7:53:50.3 PM:VERBOSE2:issuers.cc(67)] GET /v1/issuers/
[Dec 08, 2021, 7:53:50.3 PM:VERBOSE6:issuers.cc(71)] URL Request:

@aseren aseren changed the title Browser runs into issuers request infinite loop. Ads process runs into issuers request infinite loop. Dec 8, 2021
@tmancey tmancey added feature/ads QA/Yes release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 8, 2021
@tmancey tmancey self-assigned this Dec 8, 2021
@tmancey
Copy link
Contributor

tmancey commented Dec 8, 2021

This issue would only occur for a fresh install if the issuers are invalid. Changed pref to use the default ping in this situation

@LaurenWags
Copy link
Member

@tmancey can you add a test plan for this one if manual QA is required? There aren't any STR.

@tmancey tmancey removed the QA/Blocked label Jan 7, 2022
@btlechowski
Copy link

btlechowski commented Jan 16, 2022

Verification passed on

Brave 1.35.85 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#11513

Retry for fetching issuers is no longer instant. It takes around 2 minutes.

1st try

[16436:16436:0117/002545.203938:VERBOSE1:issuers.cc(80)] OnGetIssuers
[16436:16436:0117/002545.203998:VERBOSE6:issuers.cc(82)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/issuers/
  Response Status Code: 200
  Response: fail
[16436:16436:0117/002545.204073:VERBOSE3:issuers.cc(93)] Failed to parse response: fail
[16436:16436:0117/002545.206639:INFO:account.cc(255)] Failed to get issuers
[16436:16436:0117/002545.206822:VERBOSE1:issuers.cc(146)] Retry fetching issuers in 0 hours, 2 minutes, 26 seconds at 12:28 AM

1st retry

[16436:16436:0117/002811.203954:VERBOSE1:issuers.cc(66)] GetIssuers
[16436:16436:0117/002811.203995:VERBOSE2:issuers.cc(67)] GET /v1/issuers/
[16436:16436:0117/002811.204012:VERBOSE6:issuers.cc(71)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/issuers/
  Method: kGet
[16436:16436:0117/002811.932165:VERBOSE1:issuers.cc(80)] OnGetIssuers
[16436:16436:0117/002811.932213:VERBOSE6:issuers.cc(82)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/issuers/
  Response Status Code: 200
  Response: fail
[16436:16436:0117/002811.932266:VERBOSE3:issuers.cc(93)] Failed to parse response: fail
[16436:16436:0117/002811.933150:INFO:account.cc(255)] Failed to get issuers
[16436:16436:0117/002811.933186:VERBOSE1:issuers.cc(146)] Retry fetching issuers in 0 hours, 1 minute, 19 seconds at 12:29 AM

Verified that after 24h, the retry time oscillates around 2h

[331:331:0204/013938.979470:INFO:account.cc(255)] Failed to get issuers
[331:331:0204/013938.979527:VERBOSE1:issuers.cc(146)] Retry fetching issuers in 2 hours, 7 minutes, 25 seconds at 3:47 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants