Skip to content

Onboarding issues from the Brave Wallet panel #19957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bbondy opened this issue Dec 7, 2021 · 3 comments · Fixed by brave/brave-core#12008
Closed

Onboarding issues from the Brave Wallet panel #19957

bbondy opened this issue Dec 7, 2021 · 3 comments · Fixed by brave/brave-core#12008
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include

Comments

@bbondy
Copy link
Member

bbondy commented Dec 7, 2021

Couple of UX problems:

  1. When opening the panel and clicking Restore, it takes you to the restore screen but the Back button doesn't work. In this case we should hide the back button.

  2. When clicking on Getting started, it takes you to the exact same thing on the full page. We should instead go to the 2nd page in that case so the user doesn't need to click Getting Started twice. This should also not have a back button in that case when coming from the panel.

Screen Shot 2021-12-06 at 7 14 19 PM

@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Dec 7, 2021
@jamesmudgett
Copy link

This one needs more UX to avoid jumping over MetaMask and crypto wallets detection specific UI. We should either support all logic from first onboarding screen within the panel or change the panel design to be less similar to the first screen of onboarding.

@bbondy
Copy link
Member Author

bbondy commented Dec 7, 2021

Good catch, I think we should probably support the same flows in the panel in that case.

@Douglashdaniel Douglashdaniel self-assigned this Jan 20, 2022
@Douglashdaniel Douglashdaniel added this to the 1.37.x - Nightly milestone Jan 27, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 25, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Mar 25, 2022

Verified with

Brave | 1.37.105 Chromium: 100.0.4896.46 (Official Build) (x86_64)
-- | --
Revision | 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS | macOS Version 12.3 (Build 21E230)

Reproduced both the duplicate onboarding as well as "Back" button not working on brave://wallet/crypto/restore-wallet page using 1.36.119.

Using 1.37.105, confirmed panel shows as per brave/brave-core#12008 (comment).
Confirmed clicking on "Learn more" button directs user to brave://wallet/crypto/onboarding.

1.36.119 1.37.105
136119 137105

Using 1.37.105, confirmed clicking "Back" button on brave://wallet/crypto/restore-wallet works and directs the user to brave://wallet/crypto/unlock as per brave/brave-core#12008 (comment).

Example Example
1 2

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 25, 2022
@rebron rebron changed the title Onboarding issues from the panel Onboarding issues from the Brave Wallet panel Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants