Skip to content

State-level ad targeting isn't auto detected and not shown in State-level ad targeting dropdown in brave://settings/rewards #19645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeetaSarvadnya opened this issue Nov 22, 2021 · 3 comments
Assignees
Labels
bug feature/rewards OS/Desktop priority/P4 Planned work. We expect to get to it "soon". rewards-2.0

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #18158
State-level ad targeting auto detected state is not showing up in brave://settings/rewards

Steps to Reproduce

  1. Clean profile 1.33.x
  2. OS region is set to US
  3. Connect Protonvpn to US - FL state (Florida state)
  4. Launch brave with staging flags and enable rewards
  5. Open ads settings in brave://rewards
  6. Auto-detected as Florida is showing up in Ads settings but not in brave://settings/rewards

Actual result:

State-level ad targeting auto detected state is not showing up in brave://settings/rewards

Brave://rewards brave://settings/rewards
image image

Expected result:

State-level ad targeting auto-detected state should be shown in brave://settings/rewards

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.33.83 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 10 Version 21H1 (Build 19043.1348)
## Version/Channel Information:
  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @emerick @Miyayes

@emerick
Copy link
Contributor

emerick commented Nov 23, 2021

Just to clarify, it is doing the right thing (i.e., auto-detecting the state). It's just not reflecting the auto-detected state in the dropdown menu.

@zenparsing zenparsing added the priority/P4 Planned work. We expect to get to it "soon". label Nov 24, 2021
@GeetaSarvadnya GeetaSarvadnya changed the title State-level ad targeting auto detected state is not showing up in brave://settings/rewards State-level ad targeting isn't auto detected and not shown in State-level ad targeting dropdown in brave://settings/rewards Nov 26, 2021
@GeetaSarvadnya
Copy link
Author

@emerick State-level ad targetting is auto-detected only in brave://rewards ads settings page, not in brave://settings/rewards. Edited the title. Thanks!

@Miyayes
Copy link
Collaborator

Miyayes commented May 16, 2023

No longer relevant since we'll be removing this from brave://settings/rewards

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/rewards OS/Desktop priority/P4 Planned work. We expect to get to it "soon". rewards-2.0
Projects
None yet
Development

No branches or pull requests

5 participants