Skip to content

Make ConnectHW screen working on both Trezor/Ledger devices #19495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spylogsster opened this issue Nov 16, 2021 · 1 comment · Fixed by brave/brave-core#11152
Closed

Make ConnectHW screen working on both Trezor/Ledger devices #19495

spylogsster opened this issue Nov 16, 2021 · 1 comment · Fixed by brave/brave-core#11152
Assignees
@spylogsster
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.33.x - Release

Comments

@spylogsster
Copy link

spylogsster commented Nov 16, 2021 •
edited
Loading

In release 1.32.x we disabled it for Trezor urgently because of the constant retries for signature actions, need to rework it to avoid redundant retries and keep retries working only when HID error appeared
@srirambv srirambv added feature/web3/wallet Integrating Ethereum+ wallet support QA/Yes labels Nov 16, 2021
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 16, 2021
@spylogsster spylogsster self-assigned this Nov 17, 2021
@spylogsster spylogsster mentioned this issue Nov 18, 2021
Merged
24 tasks
@spylogsster spylogsster added this to the 1.34.x - Nightly milestone Nov 23, 2021
This was referenced Nov 24, 2021
Merged
Merged
Closed
@srirambv
Copy link
Contributor

srirambv commented Dec 2, 2021

Brave 1.33.98 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22504.1010) 		☑️ macOS Version 12.0.1
(Build 21A559)
  • Verified able to Sign transactions and messages by Ledger and Trezor
  • Verified Ledger throws error when trying to connect without enabling Ethereum app
  • Verified Trezor shows connect hardware screen
  • Encountered #19858 & #19873
Trezor Disconnected
Trezor Connected

@LaurenWags LaurenWags mentioned this issue Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Make ConnectHW screen working for both Trezor/Ledger devices brave/brave-core
4 participants
@bbondy @kjozwiak @spylogsster @srirambv