Skip to content

Don't treat unknown balances as 0, show N/A instead. #19404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bbondy opened this issue Nov 12, 2021 · 2 comments · Fixed by brave/brave-core#11159
Closed

Don't treat unknown balances as 0, show N/A instead. #19404

bbondy opened this issue Nov 12, 2021 · 2 comments · Fixed by brave/brave-core#11159
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.33.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Nov 12, 2021 •
edited
Loading

When displaying any token balance, we should never assume a value of 0 if we can't obtain the value.
0 is not a good default to display to users because it will scare them into thinking they've lost funds.

The only time we should display 0 is if a successful result tells us the value is 0.
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 12, 2021
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 12, 2021
@Douglashdaniel Douglashdaniel self-assigned this Nov 16, 2021
@Douglashdaniel Douglashdaniel mentioned this issue Nov 18, 2021
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.34.x - Nightly milestone Nov 22, 2021
@Douglashdaniel Douglashdaniel mentioned this issue Nov 23, 2021
Merged
7 tasks
@srirambv
Copy link
Contributor

Brave 1.33.93 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22504.1010) 		☑️ macOS Version 12.0.1
(Build 21A559)
  • Verified balance is not shown as 0 when its not yet fetched

@srirambv
Copy link
Contributor

srirambv commented Dec 3, 2021

Verification passed on Oppo Reno 5 with Android 11 running 1.33.98 x64 build

  • Verified balance is not shown as 0 when balance is not fetched

Verification passed on Samsung Tab A with Android 10 running 1.33.98 x64 build

  • Verified balance is not shown as 0 when balance is not fetched

@LaurenWags LaurenWags mentioned this issue Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Don't show 0 for Unknown Balances brave/brave-core
4 participants
@bbondy @kjozwiak @srirambv @Douglashdaniel