Skip to content

Input value should be reset to 0 when network is changed #19354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srirambv opened this issue Nov 10, 2021 · 1 comment · Fixed by brave/brave-core#11357
Closed

Input value should be reset to 0 when network is changed #19354

srirambv opened this issue Nov 10, 2021 · 1 comment · Fixed by brave/brave-core#11357
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Input value should be reset to 0 when network is changed.

Steps to Reproduce

  1. Set network to Ethereum
  2. Click preset value on send tab
  3. Change network where there is no balance
  4. Because the preset value is already set and new network doesn't have balance shows insufficient funds message

Actual result:

Screen.Recording.2021-11-10.at.11.21.06.AM.mov

Expected result:

Maybe reset so it doesn't keep showing Insufficient funds error message when network is changed

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.95 Chromium: 95.0.4638.69 (Official Build) beta (x86_64)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @jamesmudgett

@srirambv srirambv added polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Nov 10, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 10, 2021
@muliswilliam muliswilliam self-assigned this Dec 1, 2021
@muliswilliam muliswilliam added this to the 1.35.x - Nightly milestone Dec 9, 2021
@srirambv
Copy link
Contributor Author

Brave 1.35.82 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue description
  • Verified input value is reset when network is changed
19354-Linux.mp4
19354-Windows.mov
19354-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants