Edges of Brave Browser go beyond screen edge when maximised

[shakeelansari63]

Description

Edges of Brave Browser go beyond screen edge when maximised

Steps to Reproduce

On XFCE open Brave Browser (v1.31.87) and maximise the window. The window edges will go beyond screen edge

Actual result:

Browser window edges go beyond screen edge due to which the window id truncateed.

Expected result:

Window should fit in the screen edge.

Reproduces how often:

Every time window is maximised.

Brave version (brave://version info)

Brave 1.31.87 Chromium: 95.0.4638.54 (Official Build) (64-bit)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS Linux
JavaScript V8 9.5.172.21
User agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.54 Safari/537.36
Command Line /usr/lib/brave-bin/brave --enable-crashpad --disable-client-side-phishing-detection --disable-domain-reliability --enable-dom-distiller --no-pings --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --enable-features=AutoupgradeMixedContent,SafetyTip,WebUIDarkMode,ReducedReferrerGranularity,PasswordImport,PrefetchPrivacyChanges,LegacyTLSEnforced,DnsOverHttps --disable-features=AppDiscoveryRemoteUrlSearch,PrivacySandboxSettings2,SignedExchangePrefetchCacheForNavigations,AutofillServerCommunication,SignedExchangeSubresourcePrefetch,NavigatorPluginsFixed,LiveCaption,TrustTokens,DirectSockets,IdleDetection,InterestCohortFeaturePolicy,CopyLinkToText,FledgeInterestGroups,SettingsLandingPageRedesign,HandwritingRecognitionWebPlatformApiFinch,FlocIdComputedEventLogging,FederatedLearningOfCohorts,ConversionMeasurement,TextFragmentAnchor,ReadLater,AutofillEnableAccountWalletStorage,FledgeInterestGroupAPI,ComputePressure,NotificationTriggers,WebOTP,NetworkTimeServiceQuerying,SubresourceWebBundles,FirstPartySets,InterestCohortAPIOriginTrial --flag-switches-begin --flag-switches-end
Executable Path /usr/lib/brave-bin/brave
Profile Path /home/freak/.config/BraveSoftware/Brave-Browser/Default
Variations AdRewardsStudy:NextPaymentDay
BraveTalkStudy:Enabled
ConversionsStudy:NewDefaultPattern
EphemeralStorageStudy:Enabled
NativeCosmeticFilteringStudy:Enabled
PermissionLifetimeReleaseStudy:Enabled
SpeedreaderReleaseStudy:Disabled

Version/Channel Information:

I am on Stable build and facing this issue.

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Screenshot is attached

[RottCliff]

I have LXLE distro, but I installed XFWM4 instead of openbox and I also use brave and I have exactly the same problem.
It sometimes fixes itself when I only just slightly correct the maximized window by few pixels by moving it. In a way, maximizing it second time by using the top screen border snap. then it maximizes properly.
Also sometimes when snapping into the corner it snaps few pixels smaller than it should, some kind of opposite of the maximized error. The problem dissappeas when I use window manager borders.
Funny thing I discovered when I turned off my compton compositor. it revealed a previously transparent, now totally black thick borders around all brave windows. I can't give you pictures right now, because i scrambled my function shortcuts, I am working on it as we speak.

[GerritPlehn]

Switching the theme from GTK+ to Classic and back is the workaround I use at the moment.

[tquetano-netflix]

Switching the theme from GTK+ to Classic and back is the workaround I use at the moment.

Toggling this makes the issue less prominent but still present, in Classic it extends beyond the edge but only slightly.

[GerritPlehn]

Switching the theme from GTK+ to Classic and back is the workaround I use at the moment.

Toggling this makes the issue less prominent but still present, in Classic it extends beyond the edge but only slightly.

The "and back" is important 😄 Your observation is correct though. Toggling to Classic makes it better, not gone, but toggling back to GTK+ afterwards fixes it for me (until I move the window at least...) 🤷

[Wise-Monk-Chan]

Same problem here with brave-browser-beta-1.32.86-linux-amd64.zip and Arch Linux XFCE
Falling back to Version 1.30.89 solves this, but the BATs disappeared.
Have them back now when again using Version 1.32.86

[buffoon86]

I have this issue too on Debian Bullseye + XFCE.
I was able to reproduce this with chrome and then I found those 2 Bugs:

https://bugs.chromium.org/p/chromium/issues/detail?id=1261797&q=maximize&can=2
https://bugs.chromium.org/p/chromium/issues/detail?id=1260821

where the latter one was just confirmed that this bug still exists. So i think we'll have to wait for upstream chromium to get this fixed.

[smarkoco]

I also have this issue with below configuration of Ubuntu Studio.

Browser: brave-browser/stable,now 1.31.88 amd64
Kernel: 5.4.0-89-lowlatency x86_64 bits: 64
Desktop: Xfce 4.14.2 Distro: Ubuntu 20.04.3 LTS (Focal Fossa)

[shakeelansari63]

Enabling "Use system title bar and borders" option makes the issue go away. But now we have to deal with title bar which looks odd.

[bsclifton]

Thanks @buffoon86 for sharing the upstream Chromium bug reports- looks like this is captured with https://bugs.chromium.org/p/chromium/issues/detail?id=1260821

[tquetano-netflix]

I just updated to 1.32.106, and notice that it has gotten better but not completely solved. If I maximize the window via the toolbar icon (next to the close icon), then it fills the window appropriately. If I drag to a window edge to trigger the same maximization, then the buggy behavior returns. It is not sticky, though; if I trigger the buggy behavior, un-maximize, and then maximize via the toolbar icon, it maximizes as expected.

[shakeelansari63]

The issue is fixed in XFWM4. Got update for XFWM4 on ArchLinux and bug is gone.

For reference -
https://github.com/archlinux/svntogit-packages/commits/packages/xfwm4/trunk