Skip to content

Tab mute and context menu mute do not reflect each other state #18428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jardous opened this issue Sep 29, 2021 · 4 comments
Closed

Tab mute and context menu mute do not reflect each other state #18428

jardous opened this issue Sep 29, 2021 · 4 comments

Comments

@jardous
Copy link

jardous commented Sep 29, 2021

Description

Tab mute and context menu mute do not reflect each other state. Need to select "Mute tab" after that "Unmute tab" disabling the audio by clicking the mute tab icon to get it in sync.

Steps to Reproduce

  1. Open new tab and go to any site that is playing audio (youtube for example)
  2. Click the speaker icon on the tab to mute the sound
  3. Right-click the tab

Actual result:

"Mute tab" item present in the context menu

Expected result:

"Unmute tab" item present in the context menu

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave | 1.29.81 Chromium: 93.0.4577.82 (Official Build) unknown (64-bit)
Revision | e3a25d9b9e2d0b728e045ec87c0aa4942aa46e4e-refs/branch-heads/4577@{#1237}
OS | Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@rebron rebron added priority/P5 Not scheduled. Don't anticipate work on this any time soon. feature/tabs-bar labels Sep 29, 2021
@rebron
Copy link
Collaborator

rebron commented Sep 29, 2021

Mute tab icon and Mute/unmute sites are two different functions.

The ux confusion is understandable but clicking on an icon to mute a tab, it's reasonable to expect folks to select that icon again to unmute versus using a right click action to an undo what they just did.

@jardous
Copy link
Author

jardous commented Sep 29, 2021

Mute tab icon and Mute/unmute sites are two different functions.

From the user point of view I do not agree

@rebron
Copy link
Collaborator

rebron commented Sep 29, 2021

If you open up 5 youtube tabs and play each tab, they will all play at the same time. You can mute each tab with the icon or you can right click one tab and mute the site and all of the youtube tabs will be muted and all subsequent youtube tabs will be muted.

It's not a matter of point of view or agreeing/disagreeing.

There's two functions. One is to mute a tab and one is to mute a site.

What it sounds like, you'd like us to add another context menu item for mute/unmute a tab.

As it is now, the speaker/mute icon wouldn't reflect the context menu because it's not the same functionality.

@jardous
Copy link
Author

jardous commented Sep 29, 2021

Fair enough - this makes sense. Thanks for explaining the difference.

@jardous jardous closed this as completed Sep 29, 2021
@rebron rebron added closed/by-author and removed feature/tabs-bar priority/P5 Not scheduled. Don't anticipate work on this any time soon. OS/Desktop labels Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants