Skip to content

Brave Beta and Brave Nightly use wrong icons in the list of default programs #17704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tonev opened this issue Aug 26, 2021 · 1 comment
Open
Labels
bug misc/icons OS/Desktop OS/Windows priority/P4 Planned work. We expect to get to it "soon".

Comments

@Tonev
Copy link
Contributor

Tonev commented Aug 26, 2021

Description

Brave Beta and Brave Nightly use wrong icons when it comes to setting them as a default program, and when users attempt to open a file with either of them.

Steps to Reproduce

  1. Right-click on a file that Brave is able to open.
  2. Click on Open with.
  3. Open the Default Programs window via Control Panel.

Actual result:

1
image
image

Expected result:

Brave Beta and Brave Nightly should use their respective icons.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.28.106 Chromium: 92.0.4515.159 (Official Build) (64-bit)
Revision 0185b8a19c88c5dfd3e6c0da6686d799e9bc3b52-refs/branch-heads/4515@{#2052}
OS Windows 7 Service Pack 1 (Build 7601)
Brave 1.29.68 Chromium: 92.0.4515.159 (Official Build) beta (64-bit)
Revision 0185b8a19c88c5dfd3e6c0da6686d799e9bc3b52-refs/branch-heads/4515@{#2052}
OS Windows 7 Service Pack 1 (Build 7601)
Brave 1.30.48 Chromium: 93.0.4577.51 (Official Build) nightly (64-bit)
Revision 762d21050e2da59930c784c09b134d0b0b148188-refs/branch-heads/4577@{#915}
OS Windows 7 Service Pack 1 (Build 7601)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

I can only test on Windows 7, I'm not aware whether newer versions of Windows display the icons correctly.

@nastavoi
Copy link

It's a hit-or-miss on WIndows 10. Brave browser icon in Task manager is also wrong.

brave1
brave2

@rebron rebron added misc/icons OS/Windows priority/P4 Planned work. We expect to get to it "soon". labels Aug 26, 2021
@rebron rebron moved this to P4 backlog in Front End May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug misc/icons OS/Desktop OS/Windows priority/P4 Planned work. We expect to get to it "soon".
Projects
Status: P4 backlog
Development

No branches or pull requests

4 participants