Skip to content

Change the Brave Shields icon when all Brave Shields features are disabled globally #17418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tonev opened this issue Aug 10, 2021 · 0 comments
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop

Comments

@Tonev
Copy link
Contributor

Tonev commented Aug 10, 2021

Description

Right now, the Brave Shields icon is only changed when users manually disable Brave Shields on a per-site basis, disabling Brave Shields globally via brave://settings/shields or Settings -> Brave shields & privacy is not taken into consideration.

I'm not sure if there are privacy features that are untied to the features displayed at brave://settings/shields and Settings -> Brave shields & privacy so the icon remains active, but even if there are, displaying an active Brave Shields icon all the time is misleading and surely doesn't represent the true state of Brave Shields.

Steps to Reproduce

  1. Fresh user profile.
  2. Disable all Brave Shields features via brave://settings/shields or Settings -> Brave shields & privacy.
  3. Visit a random website.

Actual result:

The Brave Shields icon appears active although all Brave Shields features are disabled globally. Hovering over the Brave Shields icon shows a Has access to this site message.

Expected result:

The Brave Shields icon should either be grayed out since all Brave Shields features are disabled globally or there should be a text indicating that Brave Shields features are disabled globally, for example hovering over the icon could show a message Brave Shields is disabled globally, check Brave settings, for example.

Why do users need an indicator that tells them whether Brave Shields is disabled globally?

  1. Users won't understand their privacy is exposed until they decide to click on the Brave Shields icon in the address bar (if they decide to do so).
  2. The Cookie blocking feature of Brave Shields is directly related to the way Brave handles all cookies globally. Disabling the feature means all cookies (first-party + third-party cookies) will be accepted by the user.

Reproduces how often:

Easily

Desktop Brave version:

Brave 1.27.111 Chromium: 92.0.4515.131 (Official Build) (64-bit)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS Windows 7 Service Pack 1 (Build 7601)
JavaScript V8 9.2.230.22
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.131 Safari/537.36
Command Line "C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe" --enable-dom-distiller --disable-domain-reliability --no-pings --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --enable-features=LegacyTLSEnforced,PasswordImport,ReducedReferrerGranularity,PrefetchPrivacyChanges,WebUIDarkMode,AutoupgradeMixedContent,SafetyTip,WinrtGeolocationImplementation --disable-features=AutofillServerCommunication,HandwritingRecognitionWebPlatformApi,SignedExchangePrefetchCacheForNavigations,AutofillEnableAccountWalletStorage,FledgeInterestGroupAPI,EnableProfilePickerOnStartup,TextFragmentAnchor,EnablePasswordsAccountStorage,LiveCaption,IdleDetection,TrustTokens,DirectSockets,FlocIdComputedEventLogging,HandwritingRecognitionWebPlatformApiFinch,LangClientHintHeader,SubresourceWebBundles,NetworkTimeServiceQuerying,SignedExchangeSubresourcePrefetch,PrivacySandboxSettings,FederatedLearningOfCohorts,WebOTP,NotificationTriggers,InterestCohortAPIOriginTrial,FirstPartySets,FledgeInterestGroups,InterestCohortFeaturePolicy --flag-switches-begin --enable-features=LegacyTLSEnforced,PasswordImport,ReducedReferrerGranularity,PrefetchPrivacyChanges,WebUIDarkMode,AutoupgradeMixedContent,SafetyTip,WinrtGeolocationImplementation,EphemeralStorage --flag-switches-end
Executable Path C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe
Profile Path C:\Users\User\AppData\Local\BraveSoftware\Brave-Browser\User Data\Default
Variations AdRewardsStudy:NextPaymentDayEphemeralStorageStudy:EnabledNativeCosmeticFilteringStudy:EnabledPermissionLifetimeReleaseStudy:Enabled

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet): Phone, Huawei Mate 10 lite
  • Android version: Android 8

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@karenkliu - #17369 (comment)

@Tonev Tonev added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
None yet
Development

No branches or pull requests

1 participant