Skip to content

VPN panel (not logged into Brave Premium) #17249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #15804
bsclifton opened this issue Jul 29, 2021 · 1 comment
Closed
Tracked by #15804

VPN panel (not logged into Brave Premium) #17249

bsclifton opened this issue Jul 29, 2021 · 1 comment
Assignees
@nullhook
Labels
feature/vpn OS/Desktop OS/macOS OS/Windows premium All issues related to Brave Premium priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.37.x - Release

Comments

@bsclifton
Copy link
Member

bsclifton commented Jul 29, 2021 •
edited
Loading

Description

When a user is NOT logged into Brave Premium, the VPN button (see #17235) should show a promotional panel. This should include a link to https://account.brave.com/plans/ (we'd need to check what price to list or if we still want to show a price, as this will be outside the US also)

Already purchased VPN? would link to account.brave.com login page

Screenshot from spec:
image
This was referenced Jul 29, 2021
Closed
Closed
Closed
Closed
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jul 30, 2021
@bsclifton
Copy link
Member Author

This is also done; looks great!

@bsclifton bsclifton added this to the 1.37.x - Nightly milestone Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullhook nullhook

Labels
feature/vpn OS/Desktop OS/macOS OS/Windows premium All issues related to Brave Premium priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
1.37.x - Release
Development

No branches or pull requests
3 participants
@bsclifton @rebron @nullhook