Skip to content

Add UI messaging/design that tells users they have 90 days to claim ad earnings and solve CAPTCHA #17133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Miyayes opened this issue Jul 23, 2021 · 4 comments · Fixed by brave/brave-core#11957
Closed

Add UI messaging/design that tells users they have 90 days to claim ad earnings and solve CAPTCHA #17133

Miyayes opened this issue Jul 23, 2021 · 4 comments · Fixed by brave/brave-core#11957
Assignees
@zenparsing
Labels
feature/ads feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include rewards-2.0
Milestone
1.37.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 23, 2021

Description

Unverified users have to go through a claim + CAPTCHA process in order to claim their ad earnings every month. These claim ad earnings buttons last for 90 days. After 90 days, they are no longer valid, and the virtual-BAT can no longer be claimed.

However, the interface does not sufficiently alert the user to this fact.

Solution

Add some kind of design or UI messaging that makes it more apparent that the user only has 90 days to claim their ad earnings.

cc: @codybanxs @jsecretan @bradleyrichter
@Miyayes Miyayes added feature/rewards design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/ads OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. labels Jul 23, 2021
@Miyayes Miyayes assigned ghost Jul 27, 2021
@Miyayes Miyayes assigned minkyeongshin and unassigned ghost Oct 6, 2021
@Miyayes
Copy link
Collaborator Author

Miyayes commented Oct 8, 2021 •
edited
Loading

For Rewards panel [edit: new designs]

I think what remains are the actual Claim buttons that appear in the brave://rewards settings page. cc: @minkyeongshin

@LaurenWags LaurenWags mentioned this issue Oct 8, 2021
Closed
@Miyayes Miyayes added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Dec 29, 2021
@Miyayes Miyayes removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Jan 12, 2022
@zenparsing zenparsing self-assigned this Jan 14, 2022
@Miyayes Miyayes mentioned this issue Jan 21, 2022
Closed
@zenparsing zenparsing mentioned this issue Jan 24, 2022
Merged
25 tasks
@zenparsing zenparsing added this to the 1.37.x - Nightly milestone Feb 2, 2022
@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 9, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 11, 2022 •
edited
Loading

Verification PASSED on


Brave | 1.37.87 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
-- | --
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS | Windows 10 Version 21H2 (Build 19044.1586)

Clean profile

  • Confirmed Ad grant available to claim UI is shown in the rewards settings page, NTP widget and BR panel
  • Confirmed number of days to claim is the same You have 91 days left to claim in all the places (settings page, NTP widget and BR panel)
  • Set the system ahead by 1 day (12th March) and the confirmed number of days to claim grants is decreased each day
  • Set the system ahead by 1 week (20th March) and the confirmed number of days to claim grants is decreased each day
Rewards settings page NTP widget BR panel
image image image
12th March - Rewards settings page 12th March - NTP widget 12th March - BR panel
image image image
20th March - Rewards settings page 20th March - NTP widget 20th March - BR panel
image image image

Upgrade profile

Before upgrade

1.36.x - Rewards settings page 1.36.x - NTP widget 1.36.x - BR panel
image image image

New UI after upgrade

1.37.x - Rewards settings page 1.37.x - NTP widget 1.37.x - BR panel
image image image
12th March - Rewards settings page 12th March - NTP widget
image image
20th March - Rewards settings page 20th March - NTP widget
image image

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Mar 11, 2022
Closed
@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 11, 2022
@btlechowski
Copy link

Verification PASSED on


Brave | 1.37.87 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
-- | --
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS | Windows 10 Version 21H2 (Build 19044.1586)

Clean profile

  • Confirmed Ad grant available to claim UI is shown in the rewards settings page, NTP widget and BR panel
  • Confirmed number of days to claim is the same You have 91 days left to claim in all the places (settings page, NTP widget and BR panel)
  • Set the system ahead by 1 day and the confirmed number of days to claim grants is decreased each day
Rewards settings page NTP widget BR panel
image image image
1 day - Rewards settings page 1 day - NTP widget
image image

Upgrade profile

Before upgrade

1.36.x - Rewards settings page 1.36.x - NTP widget 1.36.x - BR panel
image image image

New UI after upgrade

1.37.x - Rewards settings page 1.37.x - NTP widget 1.37.x - BR panel
image image image
1day - Rewards settings page 1day - NTP widget
image image

@btlechowski btlechowski mentioned this issue Mar 26, 2022
Closed
@stephendonner
Copy link

Verification PASSED on

Brave 1.37.107 Chromium: 100.0.4896.46 (Official Build) (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.5 (Build 20G527)

Clean profile

  • Confirmed Ad grant available to claim UI is shown in the rewards settings page, NTP widget and BR panel
  • Confirmed number of days to claim is the same You have 91 days left to claim in all the places (settings page, NTP widget and BR panel)
  • Set the system ahead by 1 day and the confirmed number of days to claim grants is decreased each day
Rewards settings page NTP widget BR panel
Screen Shot 2022-03-28 at 10 08 38 AM Screen Shot 2022-03-28 at 10 04 55 AM Screen Shot 2022-03-28 at 10 08 24 AM
1 day - Rewards settings page 1 day - NTP widget
Screen Shot 2022-03-29 at 10 35 03 AM Screen Shot 2022-03-29 at 10 35 12 AM

Upgrade profile

Before upgrade

1.36.x - Rewards settings page 1.36.x - NTP widget 1.36.x - BR panel
Screen Shot 2022-03-28 at 10 28 31 AM Screen Shot 2022-03-28 at 10 28 35 AM Screen Shot 2022-03-28 at 10 28 46 AM

New UI after upgrade

1.37.x - Rewards settings page 1.37.x - NTP widget 1.37.x - BR panel
Screen Shot 2022-03-28 at 10 32 03 AM Screen Shot 2022-03-28 at 10 32 07 AM Screen Shot 2022-03-28 at 10 31 58 AM
1day - Rewards settings page 1day - NTP widget 1day - BR panel
Screen Shot 2022-03-29 at 10 32 58 AM Screen Shot 2022-03-29 at 10 33 04 AM Screen Shot 2022-03-29 at 10 33 08 AM

@kjozwiak kjozwiak mentioned this issue Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/ads feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include rewards-2.0
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

Update grant claim notification UI brave/brave-core
6 participants
@stephendonner @zenparsing @Miyayes @btlechowski @GeetaSarvadnya @minkyeongshin