-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Inconsistent main menu capitalization #16503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
OS/Desktop
polish
Nice to have — usually related to front-end/visual tasks
priority/P4
Planned work. We expect to get to it "soon".
QA Pass-macOS
QA/Yes
release-notes/exclude
Milestone
Comments
24 tasks
@rebron Any progress? |
"Create a New Profile" should be "Create a new profile" |
Verified
with the caveat that the changes are incomplete and will be addressed in #17309 for Windows and Linux, and #17308 for macOS. Changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
OS/Desktop
polish
Nice to have — usually related to front-end/visual tasks
priority/P4
Planned work. We expect to get to it "soon".
QA Pass-macOS
QA/Yes
release-notes/exclude
Description
The main menu in Brave is capitalized inconsistently with title case and sentence case. As with Chromium's go/punctuation-standards as well as Brave's standards, these should all be sentence case.
Steps to Reproduce
Actual result:
Soon, this seems to also affect "New Private window too, which should be "New private window

Sentence and title case are mixed.
Expected result:
Only sentence case is used, except for Brave's proper nouns such as Brave Rewards.
"Create a New Profile" should be "Create a new profile"
"Open Guest Window" should be "Open guest window"
"Report a Broken Site" should be "Report a broken site"
"New Private window" should be "New private window"
Reproduces how often:
Always
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
I've opened a pull request here for it, it has a very simple solution. brave/brave-core#8961
The text was updated successfully, but these errors were encountered: