-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Use connect wallet modal on Rewards page #16178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Verified
Uphold (US) - < 15 BATSteps:
Uphold (Spain) - < 15 BATSteps:
Uphold (France) - < 15 BATSteps:
bitFlyer (Japan)Steps:
Uphold > 15 BATConfirmed that if the user has > 15 BAT (by accepting the UGP grant on staging), before clicking
Additional
|
Example | Example | Example | Example | Example | Example |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Verify wallet connect modal via Rewards settings page_when wallet balance is `0`
- Confirmed click on
Verify wallet
via Rewards settings page displays theVerifying Optional
modal popup - Confirmed
Verifying Optional
modal popup contents is displayed as per the Figma spec - Confirmed
Choose a wallet service
modal popup contents is displayed as per the Figma spec - Confirmed click on
Uphold
displayed the message asuphold requires min balance of 15 BAT to create a new uphold account
along with uphold login link - Confirmed user can connect existing uphold account
Example | Example | Example | Example | Example | Example |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Verify wallet connect modal via BR Panel_ when wallet balance is greater than 15 BAT
- Verified the wallet connect modal flow
- Confirmed click on
Uphold
redirects uphold Authorization page - Confirmed user can create a new uphold account or connect existing uphold account
Example | Example | Example | Example | Example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Verify wallet connect modal via Rewards settings page_ when wallet balance is greater than 15 BAT
- Verified the wallet connect modal flow
- Confirmed click on
Uphold
redirects uphold Authorization page - Confirmed user can create a new uphold account or connect existing uphold account
Example | Example | Example | Example | Example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Verify wallet connect modal via BR Panel_ when wallet balance is less than 15 BAT
- Verified the wallet connect modal flow
- Confirmed click on
Uphold
displayed the message asuphold requires min balance of 15 BAT to create a new uphold account
along with uphold login link - Confirmed user can connect existing uphold account
Example | Example | Example | Example | Example | Example |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Verify wallet connect modal via Rewards settings page_ when wallet balance is less than 15 BAT
- Verified the wallet connect modal flow
- Confirmed click on
Uphold
displayed the message asuphold requires min balance of 15 BAT to create a new uphold account
along with uphold login link - Confirmed user can connect existing uphold account
Example | Example | Example | Example | Example | Example |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Verify wallet connect modal via BR Panel_ when wallet balance is equals to 15 BAT
- Verified the wallet connect modal flow
- Confirmed click on
Uphold
redirects uphold Authorization page - Confirmed user can create a new uphold account or connect existing uphold account
Example | Example | Example | Example | Example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Verify wallet connect modal via Rewards settings page_ when wallet balance is equals to 15 BAT
- Verified the wallet connect the modal flow
- Confirmed click on
Uphold
redirects uphold Authorization page - Confirmed user can create a new uphold account or connect existing uphold account
Example | Example | Example | Example | Example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Upgrade Profile
Install 1.26.x enable rewards and upgrade profile to 1.27.x and verify wallet connect modal
- Verified the wallet connect the modal flow
- Confirmed click on
Verify wallet
via Panel or Rewards settings page displays theVerifying Optional
modal popup - Confirmed click on
Uphold
displayed the message asuphold requires min balance of 15 BAT to create a new uphold account
along with uphold login link - Confirmed user can connect existing uphold account
Install 1.26.x enable rewards, claim UGP grants and upgrade profile to 1.27.x and verify wallet connect modal
- Verified the wallet connect the modal flow
- Confirmed click on
Uphold
redirects uphold Authorization page - Confirmed user can create a new uphold account or connect existing uphold account
Install 1.26.x enable rewards, make sure wallet balance is equals to 15 BAT and upgrade profile to 1.27.x and verify wallet connect modal
- Verified the wallet connect the modal flow
- Confirmed click on
Uphold
redirects uphold Authorization page - Confirmed user can create a new uphold account or connect existing uphold account
#############################bitFlyer(Japan)################################################
Clean Profile
- Translated Japanese content into English using Google translator and confirmed content of the wallet modal is shown as expected
- Confirmed
Verifying is optional
pop up modal content is shown as expected for the Japan region - Confirmed click on
Continue
button opens upChoose a wallet service
modal popup - Confirmed
bitFlyer
wallet service option is provided inChoose a wallet service
modal popup - Confirmed click on bitFlyer redirects to bitFlyer authentication/login page
- Confirmed that users can connect bitFlyer accounts
Verified the wallet connect modal viaVerify wallet
onboarding flow
Example | Example | Example | Example | Example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Verified the wallet connect modal via BR panel
Example | Example | Example | Example | Example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Verified the wallet connect modal via Rewards settings page
Example | Example | Example | Example | Example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Upgrade profile
- Installed 1.26.x and upgraded profile to 1.27.x enabled rewards and verified wallet connect modal via BR panel/Rewards settings page/ Rewards onboarding flow
- Installed 1.26.x and claimed UGP grants and upgraded profile to 1.27.x and verified wallet connect modal via BR panel/Rewards settings page
- Installed 1.26.x and claimed UGP grants and make sure wallet balance is equals to 15 BAT and upgraded profile to 1.27.x and verified wallet connect modal via BR panel/Rewards settings page
Wallet balance is less than 15 BAT
- Verified the wallet connect the modal flow
- Confirmed click on
Uphold
displayed the message asuphold requires min balance of 15 BAT to create a new uphold account
along with uphold login link - Confirmed user can connect existing uphold account
Example | Example | Example | Example | Example | Example |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Wallet balance is greater than 15 BAT
- Verified the wallet connect the modal flow
- Confirmed click on
Uphold
redirects uphold Authorization page - Confirmed user can create a new uphold account or connect existing uphold account
Example | Example | Example | Example | Example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Verified passed with
Brave 1.27.89 Chromium: 91.0.4472.124 (Official Build) beta (64-bit)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS Linux
Uphold (non-Japan region)
Spot checked to confirm new UI is available.
Confirmed that Uphold is the only custodian listed.
Confirmed that if you select Uphold without 15 BAT you get the warning message.
Confirmed that if you select Uphold with 15 BAT you do not get the warning message and are directed to Uphold's site (staging env).
Confirmed able to connect a KYC'd Uphold account (staging env).
Example | Example | Example |
---|---|---|
![]() |
![]() |
![]() |
bitFlyer (Japan region)
Spot checked to confirm new UI is available.
Confirmed that bitFlyer is the only custodian listed.
Confirmed there is no minimum balance message for bitFlyer.
Confirmed that if you select bitFlyer you are directed to their site (staging env).
Confirmed able to connect a KYC'd bitFlyer account (staging env).
Example | Example |
---|---|
![]() |
![]() |
The Rewards page should be updated to display the new connect wallet modal added in #15787. The old "blue" verification modal will no longer be displayed after this change.
The text was updated successfully, but these errors were encountered: