Skip to content

Use connect wallet modal on Rewards page #16178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zenparsing opened this issue Jun 1, 2021 · 1 comment · Fixed by brave/brave-core#8986
Closed

Use connect wallet modal on Rewards page #16178

zenparsing opened this issue Jun 1, 2021 · 1 comment · Fixed by brave/brave-core#8986

Comments

@zenparsing
Copy link

The Rewards page should be updated to display the new connect wallet modal added in #15787. The old "blue" verification modal will no longer be displayed after this change.

@stephendonner
Copy link

stephendonner commented Jun 22, 2021

Verified PASSED using

Brave 1.27.76 Chromium: 91.0.4472.114 (Official Build) dev (x86_64)
Revision 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS macOS Version 11.4 (Build 20F71)

Uphold (US) - < 15 BAT

Steps:

  1. new profile
  2. launched Brave using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
  3. opened a new tab
  4. clicked on Start using Brave Rewards, skip tour
  5. clicked on the BAT icon in the URL bar
  6. clicked on Verify Wallet
  7. clicked on Continue >
  8. clicked on Uphold
  9. clicked on Continue to login
  10. clicked on Authorize
  11. logged in to Uphold
  12. confirmed I saw my balance, and Wallet Verified state
example example example example example example
Screen Shot 2021-06-22 at 3 36 22 PM Screen Shot 2021-06-22 at 3 37 43 PM Screen Shot 2021-06-22 at 3 37 50 PM Screen Shot 2021-06-22 at 3 38 40 PM Screen Shot 2021-06-22 at 3 53 20 PM Screen Shot 2021-06-22 at 3 40 11 PM

Uphold (Spain) - < 15 BAT

Steps:

  1. set OS region to Spain, and language to Spanish
  2. new profile
  3. launched Brave using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
  4. opened a new tab
  5. clicked on Empezar a utilizar Brave Rewards
  6. clicked on the BAT icon in the URL bar, click to skip tour
  7. clicked on Verificar Monidero
  8. clicked on Continuar >
  9. clicked on Uphold
  10. clicked on Continúa para iniciar sesión
  11. clicked on Siguente
  12. logged in to Uphold
  13. confirmed I saw my balance, and Wallet Verified state
example example example example example example
Captura de pantalla 2021-06-23 a las 14 46 42 Captura de pantalla 2021-06-23 a las 14 46 46 Captura de pantalla 2021-06-23 a las 14 46 48 Captura de pantalla 2021-06-23 a las 14 46 52 Captura de pantalla 2021-06-23 a las 14 46 56 Captura de pantalla 2021-06-23 a las 14 47 12

Uphold (France) - < 15 BAT

Steps:

  1. set OS region to France, and language to French
  2. new profile
  3. launched Brave using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
  4. opened a new tab
  5. clicked on Commencez a utiliser Brave Rewards
  6. clicked on the BAT icon in the URL bar, click to skip tour
  7. clicked on Verificar Monidero
  8. clicked on Continuar >
  9. clicked on Uphold
  10. clicked on connectez-vous.
  11. clicked on Siguente
  12. logged in to Uphold
  13. confirmed I saw my balance, and Wallet Verified state
example example example example example example
Capture d’écran 2021-06-23 à 13 57 58 Capture d’écran 2021-06-23 à 13 58 03 Capture d’écran 2021-06-23 à 14 37 33 Capture d’écran 2021-06-23 à 14 37 39 Capture d’écran 2021-06-23 à 14 37 46 Capture d’écran 2021-06-23 à 14 38 09

bitFlyer (Japan)

Steps:

  1. new profile; OS region and language set to Japan and Japanese, respectively
  2. launched Brave using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
  3. opened a new tab
  4. clicked on Start using Rewards
  5. clicked on the BAT icon in the URL bar
  6. clicked on Verify Wallet
  7. clicked on Continue >
  8. clicked on bitFlyer
  9. logged in using QA's test credentials
  10. confirmed I saw a balance, and Wallet Verified state
example example example example example
スクリーンショット 2021-06-22 15 46 33 スクリーンショット 2021-06-22 15 46 55 スクリーンショット 2021-06-22 15 46 59 スクリーンショット 2021-06-22 15 49 01 スクリーンショット 2021-06-22 16 04 29

Uphold > 15 BAT

Confirmed that if the user has > 15 BAT (by accepting the UGP grant on staging), before clicking Verify Wallet, we forgo the following 1st screen here, and go directly to Uphold login

< 15 BAT accept UGP grant of 30.00 BAT > 15 BAT
Screen Shot 2021-06-23 at 3 17 20 PM Screen Shot 2021-06-23 at 3 18 53 PM Screen Shot 2021-06-23 at 3 18 59 PM

Additional Verify Wallet entrypoints

Verified in all of the above locales (US, Spain, France, Japan) that the following Verify Wallet entrypoints/links were translated, working, and I could successfully log in to Uphold/bitFlyer, as appropriate:

  1. Verify Wallet on brave://rewards panel
  2. Add Funds in brave://rewards panel
  3. Withdraw Funds in brave://rewards panel
  4. verify link in Your Brave wallet is powered by Uphold. gray section, near the bottom right of brave://rewards

Verification passed on

Brave | 1.27.78 Chromium: 91.0.4472.114 (Official Build) beta (64-bit)
-- | --
Revision | 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS | Windows 10 OS Version 2004 (Build 19041.1052)

#############################Uphold US Region################################################

Clean Profile

Verify wallet connect modal via BR Panel_ when wallet balance is `0`
  • Confirmed click on Verify wallet via BR panel displays the Verifying Optional modal popup
  • Confirmed Verifying Optional modal popup contents is displayed as per the Figma spec
  • Confirmed Choose a wallet service modal popup contents is displayed as per the Figma spec
  • Confirmed click on Uphold displayed the message as uphold requires min balance of 15 BAT to create a new uphold account along with uphold login link
  • Confirmed user can connect existing uphold account
Example Example Example Example Example Example
image image image image image image
Verify wallet connect modal via Rewards settings page_when wallet balance is `0`
  • Confirmed click on Verify wallet via Rewards settings page displays the Verifying Optional modal popup
  • Confirmed Verifying Optional modal popup contents is displayed as per the Figma spec
  • Confirmed Choose a wallet service modal popup contents is displayed as per the Figma spec
  • Confirmed click on Uphold displayed the message as uphold requires min balance of 15 BAT to create a new uphold account along with uphold login link
  • Confirmed user can connect existing uphold account
Example Example Example Example Example Example
image image image image image image
Verify wallet connect modal via BR Panel_ when wallet balance is greater than 15 BAT
  • Verified the wallet connect modal flow
  • Confirmed click on Uphold redirects uphold Authorization page
  • Confirmed user can create a new uphold account or connect existing uphold account
Example Example Example Example Example
image image image image image
Verify wallet connect modal via Rewards settings page_ when wallet balance is greater than 15 BAT
  • Verified the wallet connect modal flow
  • Confirmed click on Uphold redirects uphold Authorization page
  • Confirmed user can create a new uphold account or connect existing uphold account
Example Example Example Example Example
image image image image image
Verify wallet connect modal via BR Panel_ when wallet balance is less than 15 BAT
  • Verified the wallet connect modal flow
  • Confirmed click on Uphold displayed the message as uphold requires min balance of 15 BAT to create a new uphold account along with uphold login link
  • Confirmed user can connect existing uphold account
Example Example Example Example Example Example
image image image image image image
Verify wallet connect modal via Rewards settings page_ when wallet balance is less than 15 BAT
  • Verified the wallet connect modal flow
  • Confirmed click on Uphold displayed the message as uphold requires min balance of 15 BAT to create a new uphold account along with uphold login link
  • Confirmed user can connect existing uphold account
Example Example Example Example Example Example
image image image image image image
Verify wallet connect modal via BR Panel_ when wallet balance is equals to 15 BAT
  • Verified the wallet connect modal flow
  • Confirmed click on Uphold redirects uphold Authorization page
  • Confirmed user can create a new uphold account or connect existing uphold account
Example Example Example Example Example
image image image image image
Verify wallet connect modal via Rewards settings page_ when wallet balance is equals to 15 BAT
  • Verified the wallet connect the modal flow
  • Confirmed click on Uphold redirects uphold Authorization page
  • Confirmed user can create a new uphold account or connect existing uphold account
Example Example Example Example Example
image image image image image

Upgrade Profile

Install 1.26.x enable rewards and upgrade profile to 1.27.x and verify wallet connect modal
  • Verified the wallet connect the modal flow
  • Confirmed click on Verify wallet via Panel or Rewards settings page displays the Verifying Optional modal popup
  • Confirmed click on Uphold displayed the message as uphold requires min balance of 15 BAT to create a new uphold account along with uphold login link
  • Confirmed user can connect existing uphold account
Install 1.26.x enable rewards, claim UGP grants and upgrade profile to 1.27.x and verify wallet connect modal
  • Verified the wallet connect the modal flow
  • Confirmed click on Uphold redirects uphold Authorization page
  • Confirmed user can create a new uphold account or connect existing uphold account
Install 1.26.x enable rewards, make sure wallet balance is equals to 15 BAT and upgrade profile to 1.27.x and verify wallet connect modal
  • Verified the wallet connect the modal flow
  • Confirmed click on Uphold redirects uphold Authorization page
  • Confirmed user can create a new uphold account or connect existing uphold account

#############################bitFlyer(Japan)################################################

Clean Profile
  • Translated Japanese content into English using Google translator and confirmed content of the wallet modal is shown as expected
  • Confirmed Verifying is optional pop up modal content is shown as expected for the Japan region
  • Confirmed click on Continue button opens up Choose a wallet service modal popup
  • Confirmed bitFlyer wallet service option is provided in Choose a wallet service modal popup
  • Confirmed click on bitFlyer redirects to bitFlyer authentication/login page
  • Confirmed that users can connect bitFlyer accounts
    Verified the wallet connect modal via Verify wallet onboarding flow
Example Example Example Example Example
image image image image image

Verified the wallet connect modal via BR panel

Example Example Example Example Example
image image image image image

Verified the wallet connect modal via Rewards settings page

Example Example Example Example Example
image image image image image
Upgrade profile
  • Installed 1.26.x and upgraded profile to 1.27.x enabled rewards and verified wallet connect modal via BR panel/Rewards settings page/ Rewards onboarding flow
  • Installed 1.26.x and claimed UGP grants and upgraded profile to 1.27.x and verified wallet connect modal via BR panel/Rewards settings page
  • Installed 1.26.x and claimed UGP grants and make sure wallet balance is equals to 15 BAT and upgraded profile to 1.27.x and verified wallet connect modal via BR panel/Rewards settings page
#############################**Uphold Germany Region**###########################################

Wallet balance is less than 15 BAT

  • Verified the wallet connect the modal flow
  • Confirmed click on Uphold displayed the message as uphold requires min balance of 15 BAT to create a new uphold account along with uphold login link
  • Confirmed user can connect existing uphold account
Example Example Example Example Example Example
image image image image image image

Wallet balance is greater than 15 BAT

  • Verified the wallet connect the modal flow
  • Confirmed click on Uphold redirects uphold Authorization page
  • Confirmed user can create a new uphold account or connect existing uphold account
Example Example Example Example Example
image image image image image

Verified passed with

Brave	1.27.89 Chromium: 91.0.4472.124 (Official Build) beta (64-bit)
Revision	7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS	Linux
Uphold (non-Japan region)

Spot checked to confirm new UI is available.
Confirmed that Uphold is the only custodian listed.
Confirmed that if you select Uphold without 15 BAT you get the warning message.
Confirmed that if you select Uphold with 15 BAT you do not get the warning message and are directed to Uphold's site (staging env).
Confirmed able to connect a KYC'd Uphold account (staging env).

Example Example Example
1 2 3
bitFlyer (Japan region)

Spot checked to confirm new UI is available.
Confirmed that bitFlyer is the only custodian listed.
Confirmed there is no minimum balance message for bitFlyer.
Confirmed that if you select bitFlyer you are directed to their site (staging env).
Confirmed able to connect a KYC'd bitFlyer account (staging env).

Example Example
B1 B2

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 23, 2021
@stephendonner stephendonner removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment