-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Refactor deprecated Brave Ads WebContents::GetURL to use GetLastCommittedURL or GetVisibleURL #15936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
dev-concern
feature/ads
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/exclude
Milestone
Comments
24 tasks
Verified
Steps:
Logs:
Verification passed on
Verified test plan from brave/brave-core#9252 Ad was shown:
User was paid for the ad
Ad was clicked
Verification passed on
Ad was shown:
User was paid for the ad
Ad was clicked
Landed event was fired after 10sec
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dev-concern
feature/ads
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/exclude
No description provided.
The text was updated successfully, but these errors were encountered: