Skip to content

Remove tab group menu setting for tablets #15450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srirambv opened this issue Apr 22, 2021 · 1 comment · Fixed by brave/brave-core#8614
Closed

Remove tab group menu setting for tablets #15450

srirambv opened this issue Apr 22, 2021 · 1 comment · Fixed by brave/brave-core#8614
Assignees
@samartnik
Labels
android-tablet-specific bug OS/Android Fixes related to Android browser functionality QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.23.x - Release #3

Comments

@srirambv
Copy link
Contributor

Description

Remove tab group menu setting for tablets

Steps to reproduce

  1. Install 1.23.73 build
  2. Open Settings -> Appearance
  3. Shows option for Tab group, nothing happens when enabled/disabled

Actual result

Android.Tab.group.setting.mp4

Expected result

No setting for Tablet as tab grouping is not available

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Tablet
  • Android version: 10

Brave version

1.23.73

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information
@srirambv srirambv mentioned this issue Apr 22, 2021
Closed
@samartnik samartnik self-assigned this Apr 22, 2021
@samartnik samartnik mentioned this issue Apr 22, 2021
Merged
24 tasks
This was referenced Apr 22, 2021
Merged
Merged
@samartnik samartnik added this to the 1.25.x - Nightly milestone Apr 22, 2021
@srirambv
Copy link
Contributor Author

Verification passed on Samsung Tab A with Android 10 running 1.23.74 x64 build

  • Verified no setting available for tab groups under Appearance
Android.Tab.group.setting.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
android-tablet-specific bug OS/Android Fixes related to Android browser functionality QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.23.x - Release #3
Development

Successfully merging a pull request may close this issue.

[Android] Fixes for Tab Groups option brave/brave-core
3 participants
@kjozwiak @srirambv @samartnik