Skip to content

Brave News error message needs translated strings #14510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephendonner opened this issue Mar 5, 2021 · 0 comments
Open

Brave News error message needs translated strings #14510

stephendonner opened this issue Mar 5, 2021 · 0 comments
Labels
feature/brave-news formerly brave-today l10n OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@stephendonner
Copy link

Description

Steps to Reproduce

  1. set your OS system language to Japanese
  2. launch Brave, open a new tab, and enable Brave Today
  3. either somehow force or encounter an error condition (disconnect from Wi-Fi, intercept request, etc.) to force the error page
  4. look at the error-page text

Actual result:

スクリーンショット 2021-03-05 午後2 35 34

Error page text is in English, stating "Brave Today is experiencing some issues. Try again."

Expected result:

Error-page text should be in Kanji.

Reproduces how often:

100% (once you hit this error condition, that is)

Brave version (brave://version info)

Brave 1.23.21 Chromium: 89.0.4389.72 (Official Build) nightly (x86_64)
変更履歴 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS macOS バージョン11.2.2(ビルド20D80)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? yes
@rebron rebron added the l10n label May 14, 2021
@bsclifton bsclifton changed the title Brave Today error message needs translated strings Brave News error message needs translated strings Jun 14, 2021
@mattmcalister mattmcalister added the priority/P4 Planned work. We expect to get to it "soon". label Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/brave-news formerly brave-today l10n OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

3 participants