Skip to content

Move Brave Wallet into its own settings section #14069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bbondy opened this issue Feb 9, 2021 · 1 comment · Fixed by brave/brave-core#7895
Closed

Move Brave Wallet into its own settings section #14069

bbondy opened this issue Feb 9, 2021 · 1 comment · Fixed by brave/brave-core#7895
Assignees
@bbondy
Labels
feature/ethereum-remote-client OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.22.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Feb 9, 2021 •
edited
Loading

Description

The extensions section of brave://settings is overused and cluttered. This issue is to move Crypto Wallets out into its own section.

Designs

Ignore the Tor parts of the image, they are tracked by #13688
image

Assets

Figma: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/?node-id=359%3A9749
@bbondy bbondy self-assigned this Feb 9, 2021
@bbondy bbondy mentioned this issue Feb 9, 2021
Merged
23 tasks
@bbondy bbondy added this to the 1.22.x - Nightly milestone Feb 9, 2021
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Mar 4, 2021
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.22.55 Chromium: 89.0.4389.72 (Official Build) beta (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Windows 10 OS Version 2009 (Build 19042.804)
Wallet
image image

Verification passed on

Brave 1.22.55 Chromium: 89.0.4389.72 (Official Build) beta (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Linux
Wallet
image image

Verification passed on

Brave 1.22.55 Chromium: 89.0.4389.72 (Official Build) beta (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS macOS Version 10.15.7 (Build 19H114
Wallet
image image

Logged #14619 as a follow up

@LaurenWags LaurenWags mentioned this issue Mar 22, 2021
Closed
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/ethereum-remote-client OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.22.x - Release
Development

Successfully merging a pull request may close this issue.

Move Brave Wallet into its own settings section brave/brave-core
2 participants
@bbondy @srirambv