Skip to content

Make ddg search engine provider enable in guest window #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simonhong opened this issue Oct 2, 2018 · 1 comment · Fixed by brave/brave-core#529
Closed

Make ddg search engine provider enable in guest window #1394

simonhong opened this issue Oct 2, 2018 · 1 comment · Fixed by brave/brave-core#529

Comments

@simonhong
Copy link
Member

Description

DDG setting doesn't work in guest window

Steps to Reproduce

  1. Open guest window
  2. Turn on ddg in ntp
  3. Check ddg is used

Actual result:

ddg isn't used

Expected result:

search engine provider should be ddg when ddg prefs is turned on

Reproduces how often:

Brave version (chrome://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
  • Does it reproduce on browser-laptop?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@btlechowski
Copy link

btlechowski commented Oct 10, 2018

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7
  • Enabling DDG doesn't update the URL Bar message until mouse over. But DDG works fine

Verified passed with

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment