Skip to content

Rewards log not deleted if Rewards are off prior to upgrade - follow up to 11260 #11372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LaurenWags opened this issue Aug 21, 2020 · 2 comments

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #11260

If you disable Rewards prior to upgrading to 1.13.x, Rewards.log is not deleted. Once you enable Rewards, then the log file gets removed.

Steps to Reproduce

  1. Install 1.12.x, enable Rewards
  2. Confirm Rewards.log exists.
  3. Turn off Rewards
  4. Upgrade to 1.13.x (rename profile if necessary).

Actual result:

Rewards.log file is not purged from profile folder

Expected result:

Logging to be removed

Reproduces how often:

easily

Desktop Brave version:

Brave 1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS macOS Version 10.14.6 (Build 18G3020)

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @rebron @mandar-brave @brave/legacy_qa

@LaurenWags LaurenWags added feature/rewards QA/Yes OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 21, 2020
@LaurenWags
Copy link
Member Author

If this is not applicable to Android please remove OS/Android tag, thanks. cc @srirambv

@NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc added closed/not-actionable and removed OS/Android Fixes related to Android browser functionality OS/Desktop QA/Yes labels Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants