Skip to content

Brave Ads regional ad relevance drop list forces you to scroll the entire page - follow up to 9200 #11095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LaurenWags opened this issue Aug 5, 2020 · 4 comments
Assignees
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. enhancement feature/ads OS/Desktop

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #9200

If you open the state level drop down on ads settings, you need to scroll the entire page to see the list. It would be nice if you only had to scroll within the drop down.

Steps to Reproduce

  1. Install version with state level ads (1.12.x or above) and have OS set to US
  2. Enable Rewards
  3. Open Ads Settings

Actual result:

Screen Shot 2020-08-05 at 10 47 22 AM

Expected result:

Smaller drop down that was limited to x number of lines (10 maybe?) and scroll within that to pick my state instead of scrolling down the whole page.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.12.107 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.11.x n/a, 1.12.x yes
  • Can you reproduce this issue with the beta channel? 1.13.x yes
  • Can you reproduce this issue with the nightly channel? 1.14.x yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @tmancey @jsecretan @brave/legacy_qa @rebron

@tmancey tmancey added suggestion blocked needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. and removed QA/Yes labels Aug 5, 2020
@tmancey tmancey changed the title [Desktop] state drop list forces you to scroll the entire page - follow up to 9200 State drop list forces you to scroll the entire page - follow up to 9200 Aug 5, 2020
@tmancey tmancey added OS/Android Fixes related to Android browser functionality enhancement and removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. suggestion blocked labels Aug 5, 2020
@btlechowski
Copy link

Reproduced on

Brave 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

image

@tmancey tmancey removed the OS/Android Fixes related to Android browser functionality label Mar 7, 2021
@tmancey tmancey changed the title State drop list forces you to scroll the entire page - follow up to 9200 Brave Ads regional ad relevance drop list forces you to scroll the entire page - follow up to 9200 Apr 13, 2023
@tmancey tmancey added design A design change, especially one which needs input from the design team blocked labels Jun 14, 2023
@aguscruiz
Copy link

Yeah I agree limiting the height is the way to go. 10 items sounds good before scroll.
Do you need a mockup for this? It seems pretty straightforward

@tmancey
Copy link
Contributor

tmancey commented Jun 15, 2023

Ok great, and yes this is simple without any mockups as no design change as such.

@tmancey tmancey removed the blocked label Jun 15, 2023
@tmancey tmancey removed the design A design change, especially one which needs input from the design team label Oct 3, 2023
@tmancey tmancey self-assigned this Oct 11, 2023
@tmancey
Copy link
Contributor

tmancey commented Oct 11, 2023

Discussed with @zenparsing and this is no longer an issue. Please test on latest builds. Thanks

@tmancey tmancey closed this as completed Oct 11, 2023
@tmancey tmancey added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Oct 11, 2023
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. enhancement feature/ads OS/Desktop
Projects
Archived in project
Development

No branches or pull requests

4 participants