-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Brave Ads regional ad relevance drop list forces you to scroll the entire page - follow up to 9200 #11095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
closed/stale
Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.
enhancement
feature/ads
OS/Desktop
Comments
Reproduced on
|
Yeah I agree limiting the height is the way to go. 10 items sounds good before scroll. |
Ok great, and yes this is simple without any mockups as no design change as such. |
Discussed with @zenparsing and this is no longer an issue. Please test on latest builds. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
closed/stale
Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.
enhancement
feature/ads
OS/Desktop
Description
Found while testing #9200
If you open the state level drop down on ads settings, you need to scroll the entire page to see the list. It would be nice if you only had to scroll within the drop down.
Steps to Reproduce
Actual result:
Expected result:
Smaller drop down that was limited to x number of lines (10 maybe?) and scroll within that to pick my state instead of scrolling down the whole page.
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @tmancey @jsecretan @brave/legacy_qa @rebron
The text was updated successfully, but these errors were encountered: