Skip to content

Ad notification marked as silent notification doesn't open ad's landing page #10926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srirambv opened this issue Jul 27, 2020 · 3 comments
Closed

Ad notification marked as silent notification doesn't open ad's landing page #10926

srirambv opened this issue Jul 27, 2020 · 3 comments
Assignees
@srirambv
Labels
bug closed/wontfix feature/ads intermittent-issue OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.15.x - Release #1

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 27, 2020 •
edited
Loading

Description

Ad notification marked as silent notification doesn't open ad's landing page

Steps to reproduce

  1. Enable rewards and ads
  2. Enable background ads
  3. Ensure ads notification show up as a silent notification
  4. Click on ad notification when the app is in the background or a different app is in focus
  5. Brave opens but landing ad page doesn't load

Scenario 2 (found by @deeppandya )

  1. Have notifications in tray
  2. Background the app
  3. Click on ad notification is not opening the landing page just the launches the app

Actual result

Ad notification marked as silent notification doesn't open ad's landing page

Expected result

Should load the ad's landing page

Issue reproduces how often

Easy when you least expect
Intermittent when you try to reproduce the issue and the result is Frustration

Issue happens on

  • Current Play Store version? Yes
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? Yeah 🙄
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

Issue originally reported by @maikelmclauflin and @samartnik on beta. I was able to reproduce the issue on release version as well
@srirambv srirambv added bug needs-investigation A bug not 100% confirmed/fixed intermittent-issue QA/Yes release-notes/include feature/ads OS/Android Fixes related to Android browser functionality labels Jul 27, 2020
@yachtcaptain23 yachtcaptain23 self-assigned this Aug 3, 2020
@tmancey tmancey added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 3, 2020
@yachtcaptain23
Copy link

Seems like some code involving notification channels was upleveled, but the lines changed in BraveChannelDefinitions.java to support Chromium's changes seems to be fine.

@tmancey tmancey removed the needs-investigation A bug not 100% confirmed/fixed label Aug 5, 2020
@tmancey tmancey changed the title [Android] Ad notification marked as silent notification doesn't open ad's landing page Ad notification marked as silent notification doesn't open ad's landing page Aug 5, 2020
@tmancey tmancey assigned tmancey and unassigned deeppandya and anthonypkeane Aug 18, 2020
@tmancey tmancey assigned srirambv and unassigned tmancey Aug 25, 2020
@tmancey
Copy link
Contributor

tmancey commented Aug 25, 2020

@srirambv Can you please retest as discussed with @deeppandya and we are unable to reproduce on 1.15.x. Thank you, Terry

@tmancey tmancey closed this as completed Aug 25, 2020
@tmancey tmancey added this to the 1.15.x - Nightly milestone Aug 27, 2020
This was referenced Sep 22, 2020
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Sep 22, 2020
Closed
@srirambv
Copy link
Contributor Author

srirambv commented Oct 1, 2020

Verification passed on Samsung Tab A with Android 10 running 1.15.69 x64 build

  • Verified both scenarios from issue description and was unable to reproduce the issue

Verification passed on OnePlus 6T with Android 10 running 1.15.69 x64 build

  • Verified both scenarios from issue description and was unable to reproduce the issue

@kjozwiak kjozwiak mentioned this issue Oct 8, 2020
Closed
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srirambv srirambv

Labels
bug closed/wontfix feature/ads intermittent-issue OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
1.15.x - Release #1
Development

No branches or pull requests
5 participants
@tmancey @deeppandya @anthonypkeane @yachtcaptain23 @srirambv