Skip to content

Audit Rewards server responses publisher follow-up #10866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emerick opened this issue Jul 22, 2020 · 1 comment · Fixed by brave/brave-core#6181
Closed

Audit Rewards server responses publisher follow-up #10866

emerick opened this issue Jul 22, 2020 · 1 comment · Fixed by brave/brave-core#6181
Assignees
@emerick
Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.14.x - Release #1

Comments

@emerick
Copy link
Contributor

emerick commented Jul 22, 2020

Perform publisher-related follow-up work for Rewards server responses brave/brave-core#5918. This portion of that work was deferred to ease rebasing of the v4 publisher list work.
@emerick emerick self-assigned this Jul 22, 2020
@emerick emerick mentioned this issue Jul 22, 2020
Merged
32 tasks
@NejcZdovc NejcZdovc added this to the 1.14.x - Nightly milestone Aug 12, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Sep 1, 2020 •
edited by btlechowski
Loading

Verification passed using

Brave | 1.14.71 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | macOS Version 10.14.6 (Build 18G3020)
Wallet funded via VG (UGP grant) only
  • Verified wallet status is Not connected in brave://rewards-internals
  • Verified checkmark is shown in BR panel as well as in Tipping banner for verified pubs
  • Verified custom banner shown (when applicable) for verified publishers
  • Verified checkmark is shown in AC table, Monthly contribution table and One-time tips panel for verified pubs
  • Verified checkmark is shown in Monthly statement for AC, Monthly contributions and One-time tips for verified pubs
  • Verified one-time tips and monthly tips processed successfully
  • Verified AC processed successfully
  • Verified wallet summary is displayed correctly
  • Verified wallet summary and monthly statement are showing the correct stats for One-time tip, monthly tip and AC
  • Verified brave://rewards-internals data is shown as expected for Contributions, General info and Promotions
  • Verified rewards summary isn't lost after browser restart
  • Verified able to tip verified pubs when AC is turned off
Wallet funded via Uphold only
  • Verified wallet status is Verified in brave://rewards-internals
  • Verified checkmark is shown in BR panel as well as in Tipping banner for KYC'd pubs
  • Verified checkmark is shown in BR panel, tipping banners for connected publishers
  • Verified KYC'd publishers do not display any messaging on panel and tip banners
  • Verified connected publishers display appropriate messaging on panel and tip banners
  • Verified custom banner shown (when applicable) for verified publishers
  • Verified checkmark is shown in AC table, Monthly contribution table and One-time tips panel for verified pubs
  • Verified checkmark is shown in Monthly statement for AC, Monthly contributions and One-time tips for verified pubs
  • Verified one-time tips and monthly tips processed successfully
  • Verified AC is successful for verified publishers
  • Verified AC is successful for connected pubs (e.g DDG)
  • Verified one-time tips sent for connected pubs isn't displayed in tips panel as expected (shows in pending table)
  • Verified recurring tips for a connected publisher is going into pending contribution list at contribution time
  • Verified wallet summary is displayed correctly
  • Verified wallet summary and monthly statement are showing the correct stats for One-time tip, monthly tip and AC
  • Verified brave://rewards-internals data is shown as expected for Contributions, General info and Promotions
  • Verified transactions are listed correctly in Uphold Recent Activity section
  • Verified rewards summary isn't lost after browser restart
  • Verified able to tip verified pubs when AC is turned off
Upgrade Checks

Installed 1.13.x and set up the following, then upgraded to 1.14.x:

  • Verified wallet balance is not lost after upgrade
  • Verified creators added in AC table are retained after upgrade
  • Verified creators in Tips list were not lost after upgrade
  • Verified creators in Monthly Contributions list were not lost after upgrade
  • Verified creators in pending list were not lost after upgrade
  • Verified Rewards summary is retained after upgrade
  • Verified creators can be added to AC list after upgrade
  • Verified creators added in AC table can be excluded and re-added
  • Turn OFF rewards switch in 1.12.x and upgrade to 1.13.x and verified that the switch state is retained and it can be enabled.
  • Turn OFF AC switch in 1.12.x and upgrade to 1.13.x and verified that the switch state is retained and it can be enabled.
  • Turn OFF Ads switch in 1.12.x and upgrade to 1.13.x and verified that the switch state is retained and it can be enabled.

Verification passed on


Brave | 1.14.74 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | Windows 10 OS Version 1903 (Build 18362.1016)
Wallet funded via VG (UGP grant) only
  • Verified wallet status is Not connected in brave://rewards-internals
  • Verified checkmark is shown in BR panel as well as in Tipping banner for verified pubs
  • Verified custom banner shown (when applicable) for verified publishers
  • Verified checkmark is shown in AC table, Monthly contribution table and One-time tips panel for verified pubs
  • Verified checkmark is shown in Monthly statement for AC, Monthly contributions and One-time tips for verified pubs
  • Verified one-time tips and monthly tips processed successfully
  • Verified AC processed successfully
  • Verified wallet summary is displayed correctly
  • Verified wallet summary and monthly statement are showing the correct stats for One-time tip, monthly tip and AC
  • Verified brave://rewards-internals data is shown as expected for Contributions, General info and Promotions
  • Verified rewards summary isn't lost after browser restart
  • Verified able to tip verified pubs when AC is turned off
Wallet funded via Uphold only
  • Verified wallet status is Verified in brave://rewards-internals
  • Verified checkmark is shown in BR panel as well as in Tipping banner for KYC'd pubs
  • Verified checkmark is shown in BR panel, tipping banners for connected publishers
  • Verified KYC'd publishers do not display any messaging on panel and tip banners
  • Verified connected publishers display appropriate messaging on panel and tip banners
  • Verified custom banner shown (when applicable) for verified publishers
  • Verified checkmark is shown in AC table, Monthly contribution table and One-time tips panel for verified pubs
  • Verified checkmark is shown in Monthly statement for AC, Monthly contributions and One-time tips for verified pubs
  • Verified one-time tips and monthly tips processed successfully
  • Verified AC is successful for verified publishers
  • Verified AC is successful for connected pubs (e.g DDG)
  • Verified one-time tips sent for connected pubs isn't displayed in tips panel as expected (shows in pending table)
  • Verified recurring tips for a connected publisher is going into pending contribution list at contribution time
  • Verified wallet summary is displayed correctly
  • Verified wallet summary and monthly statement are showing the correct stats for One-time tip, monthly tip and AC
  • Verified brave://rewards-internals data is shown as expected for Contributions, General info and Promotions
  • Verified transactions are listed correctly in Uphold Recent Activity section
  • Verified rewards summary isn't lost after browser restart
  • Verified able to tip verified pubs when AC is turned off
Upgrade Checks

Installed 1.13.x and set up the following, then upgraded to 1.14.x:

  • Verified wallet balance is not lost after upgrade
  • Verified creators added in AC table are retained after upgrade
  • Verified creators in Tips list were not lost after upgrade
  • Verified creators in Monthly Contributions list were not lost after upgrade
  • Verified creators in pending list were not lost after upgrade
  • Verified Rewards summary is retained after upgrade
  • Verified creators can be added to AC list after upgrade
  • Verified creators added in AC table can be excluded and re-added
  • Turn OFF rewards switch in 1.12.x and upgrade to 1.14.x and verified that the switch state is retained and it can be enabled.
  • Turn OFF AC switch in 1.12.x and upgrade to 1.14.x and verified that the switch state is retained and it can be enabled.
  • Turn OFF Ads switch in 1.12.x and upgrade to 1.14.x and verified that the switch state is retained and it can be enabled.

Verification passed on

Brave 1.14.75 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS
Wallet funded via VG (UGP grant) only
  • Verified wallet status is Not connected in brave://rewards-internals
  • Verified checkmark is shown in BR panel as well as in Tipping banner for verified pubs
  • Verified custom banner shown (when applicable) for verified publishers
  • Verified checkmark is shown in AC table, Monthly contribution table and One-time tips panel for verified pubs
  • Verified checkmark is shown in Monthly statement for AC, Monthly contributions and One-time tips for verified pubs
  • Verified one-time tips and monthly tips processed successfully
  • Verified AC processed successfully
  • Verified wallet summary is displayed correctly
  • Verified wallet summary and monthly statement are showing the correct stats for One-time tip, monthly tip and AC
  • Verified brave://rewards-internals data is shown as expected for Contributions, General info and Promotions
  • Verified rewards summary isn't lost after browser restart
  • Verified able to tip verified pubs when AC is turned off
Wallet funded via Uphold only
  • Verified wallet status is Verified in brave://rewards-internals
  • Verified checkmark is shown in BR panel as well as in Tipping banner for KYC'd pubs
  • Verified checkmark is shown in BR panel, tipping banners for connected publishers
  • Verified KYC'd publishers do not display any messaging on panel and tip banners
  • Verified connected publishers display appropriate messaging on panel and tip banners
  • Verified custom banner shown (when applicable) for verified publishers
  • Verified checkmark is shown in AC table, Monthly contribution table and One-time tips panel for verified pubs
  • Verified checkmark is shown in Monthly statement for AC, Monthly contributions and One-time tips for verified pubs
  • Verified one-time tips and monthly tips processed successfully
  • Verified AC is successful for verified publishers
  • Verified AC is successful for connected pubs (e.g DDG)
  • Verified one-time tips sent for connected pubs isn't displayed in tips panel as expected (shows in pending table)
  • Verified recurring tips for a connected publisher is going into pending contribution list at contribution time
  • Verified wallet summary is displayed correctly
  • Verified wallet summary and monthly statement are showing the correct stats for One-time tip, monthly tip and AC
  • Verified brave://rewards-internals data is shown as expected for Contributions, General info and Promotions
  • Verified transactions are listed correctly in Uphold Recent Activity section
  • Verified rewards summary isn't lost after browser restart
  • Verified able to tip verified pubs when AC is turned off
Upgrade Checks

Installed 1.13.x and set up the following, then upgraded to 1.14.x:

  • Verified wallet balance is not lost after upgrade
  • Verified creators added in AC table are retained after upgrade
  • Verified creators in Tips list were not lost after upgrade
  • Verified creators in Monthly Contributions list were not lost after upgrade
  • Verified creators in pending list were not lost after upgrade
  • Verified Rewards summary is retained after upgrade
  • Verified creators can be added to AC list after upgrade
  • Verified creators added in AC table can be excluded and re-added
  • Turn OFF rewards switch in 1.12.x and upgrade to 1.14.x and verified that the switch state is retained and it can be enabled.
  • Turn OFF AC switch in 1.12.x and upgrade to 1.14.x and verified that the switch state is retained and it can be enabled.
  • Turn OFF Ads switch in 1.12.x and upgrade to 1.14.x and verified that the switch state is retained and it can be enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.14.x - Release #1
Development

Successfully merging a pull request may close this issue.

Rewards server responses - publisher followup work brave/brave-core
5 participants
@emerick @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya