Skip to content

[Android] Inject cosmetic filtering scriptlets in all frames #10436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kjozwiak opened this issue Jun 24, 2020 · 1 comment · Fixed by brave/brave-core#5931
Closed

[Android] Inject cosmetic filtering scriptlets in all frames #10436

kjozwiak opened this issue Jun 24, 2020 · 1 comment · Fixed by brave/brave-core#5931
Assignees
Labels
bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@kjozwiak
Copy link
Member

Description

Similar to #10319, we need to make sure that ads aren't appearing under embedded YT videos.

Steps to reproduce

  1. download/install 1.10.95 CR: 83.0.4103.106
  2. visit https://www.pcmag.com/news/the-best-vr-games-for-2019 and play through a few of the videos

Actual result

You'll see ads being played that aren't skippable as per the following:

Screenshot_20200623-225112_Brave

Expected result

Ads shouldn't appear while playing through embedded videos.

Issue reproduces how often

100% reproducible when using the STR mentioned above. Sometimes you'll need to run through a few videos before seeing videos.

Issue happens on

  • Current Play Store version? Yes (reproduced with 1.10.95 CR: 83.0.4103.106)
  • Beta build? Yes (reproduced with 1.10.96 CR: 83.0.4103.106)

However, can't reproduce with Nightly using 1.12.45 CR: 83.0.4103.116

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Samsung S10+
  • Android version: Android 10

Brave version

  • Using 1.10.95 CR: 83.0.4103.106 (Release) & 1.10.96 CR: 83.0.4103.106 (Beta)

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @bsclifton @antonok-edm @anthonypkeane @SergeyZhukovsky @srirambv

@srirambv
Copy link
Contributor

srirambv commented Jun 25, 2020

Verification passed on Samsung Tab A with Android 9 running 1.10.98 x64 build

  • Verified test plan from issue description
  • Verified on both clean install and upgrade install
  • Verified on multiple sites with embedded videos
  • Verified no ads when using a VPN and viewing embedded videos

Verification passed on Samsung Galaxy J3 version 5.1.1 running Bravemodernarm.apk 1.10.98

  • Verified test plan from issue description
  • Verified on both clean install and upgrade install
  • Verified on multiple sites with embedded videos
  • Verified no ads when using a VPN and viewing embedded videos

Verification passed on Asus Zenfone (x86) version 6 running Bravemodernarm.apk 1.10.99

  • Verified test plan from issue description
  • Verified on both clean install and upgrade install
  • Verified on multiple sites with embedded videos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants