Fix crash in BraveStatsUpdater when computer wakes from suspend

Fix #1116

Author: pilgrim-brave

browser/brave_stats_updater.cc

@@ -15,6 +15,7 @@
 #include "brave/browser/version_info.h"
 #include "net/base/load_flags.h"
 #include "net/base/url_util.h"
+#include "net/http/http_response_headers.h"
 #include "net/traffic_annotation/network_traffic_annotation.h"
 #include "services/network/public/cpp/resource_request.h"
 #include "services/network/public/cpp/simple_url_loader.h"
@@ -24,9 +25,6 @@ const char kBaseUpdateURL[] = "https://laptop-updates.brave.com/1/usage/brave-co
 // Ping the update server once an hour.
 const int kUpdateServerPingFrequency = 60 * 60;
 
-// Maximum size of the server ping response in bytes.
-const int kMaxUpdateServerPingResponseSizeBytes = 1024 * 1024;
-
 namespace {
 
 std::string GetChannelName() {
@@ -100,19 +98,16 @@ void BraveStatsUpdater::Stop() {
 
 void BraveStatsUpdater::OnSimpleLoaderComplete(
     std::unique_ptr<brave::BraveStatsUpdaterParams> stats_updater_params,
-    std::unique_ptr<std::string> response_body) {
+    scoped_refptr<net::HttpResponseHeaders> headers) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   int response_code = -1;
-  if (simple_url_loader_->ResponseInfo() &&
-      simple_url_loader_->ResponseInfo()->headers)
-    response_code =
-        simple_url_loader_->ResponseInfo()->headers->response_code();
+  if (headers)
+    response_code = headers->response_code();
   if (simple_url_loader_->NetError() != net::OK || response_code < 200 ||
       response_code > 299) {
     LOG(ERROR) << "Failed to send usage stats to update server"
                << ", error: " << simple_url_loader_->NetError()
                << ", response code: " << response_code
-               << ", payload: " << *response_body
                << ", url: " << simple_url_loader_->GetFinalURL().spec();
     return;
   }
@@ -155,12 +150,10 @@ void BraveStatsUpdater::OnServerPingTimerFired() {
           ->GetURLLoaderFactory();
   simple_url_loader_ = network::SimpleURLLoader::Create(
       std::move(resource_request), traffic_annotation);
-  simple_url_loader_->SetAllowHttpErrorResults(true);
-  simple_url_loader_->DownloadToString(
+  simple_url_loader_->DownloadHeadersOnly(
       loader_factory,
       base::BindOnce(&BraveStatsUpdater::OnSimpleLoaderComplete,
-                     base::Unretained(this), std::move(stats_updater_params)),
-      kMaxUpdateServerPingResponseSizeBytes);
+                     base::Unretained(this), std::move(stats_updater_params)));
 }
 
 ///////////////////////////////////////////////////////////////////////////////

browser/brave_stats_updater.h

@@ -13,6 +13,10 @@
 class PrefRegistrySimple;
 class PrefService;
 
+namespace net {
+class HttpResponseHeaders;
+}
+
 namespace network {
 class SimpleURLLoader;
 }
@@ -33,7 +37,7 @@ class BraveStatsUpdater {
   // Invoked from SimpleURLLoader after download is complete.
   void OnSimpleLoaderComplete(
       std::unique_ptr<brave::BraveStatsUpdaterParams> stats_updater_params,
-      std::unique_ptr<std::string> response_body);
+      scoped_refptr<net::HttpResponseHeaders> headers);
 
   // Invoked from RepeatingTimer when server ping timer fires.
   void OnServerPingTimerFired();