Fix IsObjNotFoundErr() for wrapped errors (#3973)

Signed-off-by: Marco Pracucci <[email protected]>

Author: pracucci

cos/cos.go

@@ -205,7 +205,7 @@ func (b *Bucket) Exists(ctx context.Context, name string) (bool, error) {
 
 // IsObjNotFoundErr returns true if error means that object is not found. Relevant to Get operations.
 func (b *Bucket) IsObjNotFoundErr(err error) bool {
-	switch tmpErr := err.(type) {
+	switch tmpErr := errors.Cause(err).(type) {
 	case *cos.ErrorResponse:
 		if tmpErr.Code == "NoSuchKey" ||
 			(tmpErr.Response != nil && tmpErr.Response.StatusCode == http.StatusNotFound) {

gcs/gcs.go

@@ -183,7 +183,7 @@ func (b *Bucket) Delete(ctx context.Context, name string) error {
 
 // IsObjNotFoundErr returns true if error means that object is not found. Relevant to Get operations.
 func (b *Bucket) IsObjNotFoundErr(err error) bool {
-	return err == storage.ErrObjectNotExist
+	return errors.Is(err, storage.ErrObjectNotExist)
 }
 
 func (b *Bucket) Close() error {

inmem.go

@@ -197,7 +197,7 @@ func (b *InMemBucket) Delete(_ context.Context, name string) error {
 
 // IsObjNotFoundErr returns true if error means that object is not found. Relevant to Get operations.
 func (b *InMemBucket) IsObjNotFoundErr(err error) bool {
-	return errors.Cause(err) == errNotFound
+	return errors.Is(err, errNotFound)
 }
 
 func (b *InMemBucket) Close() error { return nil }

oss/oss.go

@@ -354,7 +354,7 @@ func (b *Bucket) Exists(ctx context.Context, name string) (bool, error) {
 
 // IsObjNotFoundErr returns true if error means that object is not found. Relevant to Get operations.
 func (b *Bucket) IsObjNotFoundErr(err error) bool {
-	switch aliErr := err.(type) {
+	switch aliErr := errors.Cause(err).(type) {
 	case alioss.ServiceError:
 		if aliErr.StatusCode == http.StatusNotFound {
 			return true

s3/s3.go

@@ -492,7 +492,7 @@ func (b *Bucket) Delete(ctx context.Context, name string) error {
 
 // IsObjNotFoundErr returns true if error means that object is not found. Relevant to Get operations.
 func (b *Bucket) IsObjNotFoundErr(err error) bool {
-	return minio.ToErrorResponse(err).Code == "NoSuchKey"
+	return minio.ToErrorResponse(errors.Cause(err)).Code == "NoSuchKey"
 }
 
 func (b *Bucket) Close() error { return nil }