Key failure causes entire job to abort

[deinspanjer]

We occasionally get keys that don't return on some requests. Currently, if that happens, the entire csv request fails. I added the following code to be able to log those problems and continue:

1.  to_csv(Pid, Bucket, Props, Csv, [Key|Keys]) -> 
2.      NewCsv = try
3.                   {ok, Object} = riakc_pb_socket:get(Pid, Bucket, Key),
4.                   Entry = doc_to_csv(Object, Props),
5.                   case Keys of
6.                       [] -> <<Csv/binary, Entry/binary>>; %% end of dump
7.                       _ -> <<Csv/binary, Entry/binary, 10>>
8.                   end
9.               catch
10.                  error:_ ->
11.                      io:fwrite("~p:~p\n", [Key,bucket]),
12.                      Csv
13.              end,
14.         to_csv(Pid, Bucket, Props, NewCsv, Keys); 

[bradfordw]

Awesome, I had labelled a few of the cases for additional error support but hadn't gotten to them yet; I had a suspicion that something bad could happen and bork the response! Thanks for the snippet, I'll get it merged in shortly.

[deinspanjer]

This was actually the most erlang I've written to date. That said, I imagine that you might want to use something better than io:fwrite so it shows up in the sasl-error log maybe?

[bradfordw]

Yea, it'll go into the error_logger:warning_msg() since I assume you want it to keep running after it's "missed" right?