Skip to content

how to set using "noreply" flag? #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangzhilong opened this issue Aug 21, 2019 · 3 comments
Open

how to set using "noreply" flag? #107

wangzhilong opened this issue Aug 21, 2019 · 3 comments

Comments

@wangzhilong
Copy link

I wan't to set with noreply flag, but no api support.

@raffy4284
Copy link

+1 here...
we can probably pull up a PR to add that optional flag on this line?
https://github.com/bradfitz/gomemcache/blob/master/memcache/memcache.go#L587
( we'd probably block it on those that support the noreply flag )

@raffy4284
Copy link

So I have something like this...trying to add testing now though:
https://github.com/bradfitz/gomemcache/pull/153/files

Currently adding unit testing as well atm for this before I mark for review...
only thing is that this changes the interface on the Delete and DeleteAll commands

@dormando
Copy link
Collaborator

dormando commented Apr 4, 2025

Leaving a note:

  • Noreply is a bit bodgy in the base text protocol. If you send a bunch of queries but something is misformatted it'll fill the connection with errors... since we can't avoid sending an error until we've parsed the request.
  • Meta handles it a bit better since we expect to handle some errors but I've had complaints that people can't just fire-and-forget in this mode.

We'll have to make a call on if it's worth implementing noreply or just go for quiet + pipelines with meta.

@dormando dormando added this to the Small protocol issues milestone Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants