Unit tests for healtcheck service

Unit tests for healtcheck service.

Author: bpineau

pkg/health/health.go

@@ -33,9 +33,9 @@ func (h *Listener) healthCheckReply(w http.ResponseWriter, r *http.Request) {
 }
 
 // Start exposes an http healthcheck handler
-func (h *Listener) Start() (*Listener, error) {
+func (h *Listener) Start() *Listener {
 	if h.config.HealthPort == 0 {
-		return h, nil
+		return h
 	}
 
 	h.config.Logger.Info("Starting http healtcheck handler")
@@ -52,7 +52,7 @@ func (h *Listener) Start() (*Listener, error) {
 		}
 	}()
 
-	return h, nil
+	return h
 }
 
 // Stop halts the http health check handler

pkg/health/health_test.go

@@ -0,0 +1,58 @@
+package health
+
+import (
+	"net/http"
+	"net/http/httptest"
+	"testing"
+
+	"github.com/sirupsen/logrus"
+	"github.com/sirupsen/logrus/hooks/test"
+
+	"github.com/bpineau/katafygio/config"
+	"github.com/bpineau/katafygio/pkg/log"
+)
+
+func TestNoopHealth(t *testing.T) {
+
+	conf := &config.KfConfig{
+		Logger:     log.New("error", "", "test"),
+		HealthPort: 0,
+	}
+
+	// shouldn't panic with 0 as port
+	hc := New(conf)
+	_ = hc.Start()
+	hc.Stop()
+
+	conf.HealthPort = -42
+	hc = New(conf)
+	_ = hc.Start()
+	hc.Stop()
+	hook := hc.config.Logger.Hooks[logrus.InfoLevel][0].(*test.Hook)
+	if len(hook.Entries) != 1 {
+		t.Error("Failed to log an issue with a bogus port")
+	}
+}
+
+func TestHealthCheck(t *testing.T) {
+	conf := &config.KfConfig{
+		Logger:     log.New("info", "", "test"),
+		HealthPort: 0,
+	}
+
+	hc := New(conf)
+
+	req, err := http.NewRequest("GET", "/health", nil)
+	if err != nil {
+		t.Error(err)
+	}
+
+	rr := httptest.NewRecorder()
+
+	handler := http.HandlerFunc(hc.healthCheckReply)
+	handler.ServeHTTP(rr, req)
+
+	if status := rr.Code; status != http.StatusOK {
+		t.Errorf("healthCheckReply handler didn't return an HTTP 200 status code")
+	}
+}

pkg/run/run.go

@@ -26,11 +26,7 @@ func Run(config *config.KfConfig) {
 	evts := event.New()
 	reco := recorder.New(config, evts).Start()
 	obsv := observer.New(config, evts, &controller.Factory{}).Start()
-
-	http, err := health.New(config).Start()
-	if err != nil {
-		config.Logger.Fatalf("failed to start http healtcheck handler: %v", err)
-	}
+	http := health.New(config).Start()
 
 	sigterm := make(chan os.Signal, 1)
 	signal.Notify(sigterm, syscall.SIGTERM)