Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message overflows window #1974

Open
2 tasks done
DougInAMug opened this issue Mar 21, 2024 · 9 comments · May be fixed by #2221
Open
2 tasks done

Error message overflows window #1974

DougInAMug opened this issue Mar 21, 2024 · 9 comments · May be fixed by #2221
Assignees
Labels
good first issue Simple change to start learning code base priority:low Nice to have feature, minor improvement to functionality or usability status:idea Proposed feature, discuss if its useful

Comments

@DougInAMug
Copy link

Description

A failed backup lead to an error message long enough to overflow the window. No scroll bar was available, so reading was only possible by dragging window partially off the top of the screen, then enlarging the window.

Screenshot from 2024-03-21 14-24-56

Reproduction

  • I tried to reproduce the issue.
  • I was able to reproduce the issue.

OS

Pop!_OS 22.04 LTS, GNOME 42.9

Version of Vorta

0.8.3

What did you install Vorta with?

Distribution package

Version of Borg

1.2.0

Logs

No response

@m3nu m3nu added priority:low Nice to have feature, minor improvement to functionality or usability status:idea Proposed feature, discuss if its useful good first issue Simple change to start learning code base labels Mar 21, 2024
@m3nu
Copy link
Contributor

m3nu commented Mar 21, 2024

Yes, could be solved better. And we already do some output parsing and could catch this and treat it differently.

We should first see how we want to solve it. Maybe as larger window, similar to Vorta's own exceptions.

@SAMAD101
Copy link
Collaborator

Yes, could be solved better. And we already do some output parsing and could catch this and treat it differently.

We should first see how we want to solve it. Maybe as larger window, similar to Vorta's own exceptions.

Vorta's own exceptions could serve well. But what would be the best ways to catch exceptions outside of the Vorta's main thread?

This could be a good addition to my projects ('Error handling & report wizard' one).
What do you think?

@shivansh02
Copy link
Collaborator

shivansh02 commented Mar 26, 2024

We should first see how we want to solve it. Maybe as larger window, similar to Vorta's own exceptions.

We can show a few lines and add a Read More button, which would open a scrollable window with all the details.

@AdwaitSalankar
Copy link
Contributor

I think it's better to have a pop-up window with a copy to clipboard button.

@shivansh02
Copy link
Collaborator

@m3nu Should I remove the error from here and just open an exception box as done in #1977?

@m3nu
Copy link
Contributor

m3nu commented Apr 1, 2024

Yes, I would use the same error box for Vorta AND Borg exceptions. Even if their content will be a bit different and the source they come from.

@shivansh02
Copy link
Collaborator

Sure, will take this up as soon as I'm done with my proposal submission.

@ahmedhosssam
Copy link

Hi, I'm working on this issue right now.

@m3nu
Copy link
Contributor

m3nu commented Mar 19, 2025

Noticed this again yesterday: #2218

I've assigned you the issue. So it's all yours.

@ahmedhosssam ahmedhosssam linked a pull request Mar 20, 2025 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Simple change to start learning code base priority:low Nice to have feature, minor improvement to functionality or usability status:idea Proposed feature, discuss if its useful
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants